refactor failed_tests_reporter to use TS, no octokit #46993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 2 commits
October 5, 2019 21:08
…ed-test-cli # Conflicts: # packages/kbn-test/tsconfig.json # yarn.lock
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
joshdover
suggested changes
Oct 8, 2019
added 7 commits
October 8, 2019 11:51
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 8, 2019
* refactor failed_tests_reporter to use TS, no octokit * update renovate config * ensure that all kbn-test files are in ts project * fix some type errors * add some more tests * [kbn-test/githubapi] cleanup and document * collect log messages as strings instead of message objects * ensure issue is open when updating body * improve readability of getKibanaIssues * expose axios helpers from dev-utils * fix request params for fetching github issues and validate locally * include a README for failed_tests_reporter * improve axios error helpers # Conflicts: # packages/kbn-test/src/index.ts # renovate.json5
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 8, 2019
* refactor failed_tests_reporter to use TS, no octokit * update renovate config * ensure that all kbn-test files are in ts project * fix some type errors * add some more tests * [kbn-test/githubapi] cleanup and document * collect log messages as strings instead of message objects * ensure issue is open when updating body * improve readability of getKibanaIssues * expose axios helpers from dev-utils * fix request params for fetching github issues and validate locally * include a README for failed_tests_reporter * improve axios error helpers # Conflicts: # package.json # packages/kbn-test/src/index.ts # packages/kbn-test/src/mocha/junit_report_generation.js # renovate.json5 # src/dev/jest/junit_reporter.js # yarn.lock
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 8, 2019
* refactor failed_tests_reporter to use TS, no octokit * update renovate config * ensure that all kbn-test files are in ts project * fix some type errors * add some more tests * [kbn-test/githubapi] cleanup and document * collect log messages as strings instead of message objects * ensure issue is open when updating body * improve readability of getKibanaIssues * expose axios helpers from dev-utils * fix request params for fetching github issues and validate locally * include a README for failed_tests_reporter * improve axios error helpers # Conflicts: # package.json # packages/kbn-dev-utils/src/axios/errors.ts # packages/kbn-dev-utils/src/index.ts # packages/kbn-dev-utils/src/kbn_client/kbn_client_requester.ts # packages/kbn-test/src/index.ts # packages/kbn-test/src/mocha/junit_report_generation.js # renovate.json5 # src/dev/jest/junit_reporter.js # yarn.lock
Contributor
Author
spalger
pushed a commit
that referenced
this pull request
Oct 9, 2019
* refactor failed_tests_reporter to use TS, no octokit (#46993) * refactor failed_tests_reporter to use TS, no octokit * update renovate config * ensure that all kbn-test files are in ts project * fix some type errors * add some more tests * [kbn-test/githubapi] cleanup and document * collect log messages as strings instead of message objects * ensure issue is open when updating body * improve readability of getKibanaIssues * expose axios helpers from dev-utils * fix request params for fetching github issues and validate locally * include a README for failed_tests_reporter * improve axios error helpers # Conflicts: # package.json # packages/kbn-test/src/index.ts # packages/kbn-test/src/mocha/junit_report_generation.js # renovate.json5 # src/dev/jest/junit_reporter.js # yarn.lock * ensure all of kbn-test is in ts project
spalger
pushed a commit
that referenced
this pull request
Oct 9, 2019
* refactor failed_tests_reporter to use TS, no octokit (#46993) * refactor failed_tests_reporter to use TS, no octokit * update renovate config * ensure that all kbn-test files are in ts project * fix some type errors * add some more tests * [kbn-test/githubapi] cleanup and document * collect log messages as strings instead of message objects * ensure issue is open when updating body * improve readability of getKibanaIssues * expose axios helpers from dev-utils * fix request params for fetching github issues and validate locally * include a README for failed_tests_reporter * improve axios error helpers # Conflicts: # package.json # packages/kbn-dev-utils/src/axios/errors.ts # packages/kbn-dev-utils/src/index.ts # packages/kbn-dev-utils/src/kbn_client/kbn_client_requester.ts # packages/kbn-test/src/index.ts # packages/kbn-test/src/mocha/junit_report_generation.js # renovate.json5 # src/dev/jest/junit_reporter.js # yarn.lock * ensure all of kbn-test is in ts project (cherry picked from commit 41134fe) * backport dev-utils constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed recently that some failures aren't being reported to github, sorta randomly, and the major upgrade to
@octokit/restis kinda tricky, so instead of working on those two issues I decided to refactor the existingfailed_tests/cliinto a part of the@kbn/testpackage that doesn't use streams,@octokit/rest, and is written in TypeScript.