collect log messages as strings instead of message objects

Author: spalger

packages/kbn-dev-utils/src/tooling_log/tooling_log_collecting_writer.ts

@@ -17,16 +17,20 @@
  * under the License.
  */
 
-import { Writer } from './writer';
-import { Message } from './message';
+import { ToolingLogTextWriter } from './tooling_log_text_writer';
 
-export class ToolingLogCollectingWriter implements Writer {
-  messages: Message[] = [];
+export class ToolingLogCollectingWriter extends ToolingLogTextWriter {
+  messages: string[] = [];
 
-  constructor() {}
-
-  write(message: Message) {
-    this.messages.push(message);
-    return true;
+  constructor() {
+    super({
+      level: 'verbose',
+      writeTo: {
+        write: msg => {
+          // trim trailing new line
+          this.messages.push(msg.slice(0, -1));
+        },
+      },
+    });
   }
 }

packages/kbn-test/src/failed_tests_reporter/report_failure.test.ts

@@ -72,13 +72,7 @@ describe('createFailureIssue()', () => {
     `);
     expect(writer.messages).toMatchInlineSnapshot(`
       Array [
-        Object {
-          "args": Array [
-            "Created issue undefined",
-          ],
-          "indent": 0,
-          "type": "info",
-        },
+        " info Created issue undefined",
       ]
     `);
   });
@@ -145,13 +139,7 @@ describe('updatedFailureIssue()', () => {
     `);
     expect(writer.messages).toMatchInlineSnapshot(`
       Array [
-        Object {
-          "args": Array [
-            "Updated issue https://github.com/issues/1234, failCount: 11",
-          ],
-          "indent": 0,
-          "type": "info",
-        },
+        " info Updated issue https://github.com/issues/1234, failCount: 11",
       ]
     `);
   });