Replace data plugin kfetch dependency with core.http service#45498
Merged
lizozom merged 7 commits intoelastic:masterfrom Sep 16, 2019
Merged
Replace data plugin kfetch dependency with core.http service#45498lizozom merged 7 commits intoelastic:masterfrom
lizozom merged 7 commits intoelastic:masterfrom
Conversation
lizozom
added
review
v8.0.0
Team:AppArch
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch |
Contributor
💔 Build Failed |
Contributor
|
ACK: will review security related change today |
lizozom
force-pushed
the
newplatform/data-plugin/remove-kfetch-2
branch
from
0066421 to
fc1e8ff
Compare
This was referenced Sep 12, 2019
lizozom
changed the title
Contributor
💚 Build Succeeded |
added 2 commits
September 15, 2019 14:01
…plugin/remove-kfetch-2
…plugin/remove-kfetch-2
Contributor
💚 Build Succeeded |
ppisljar
approved these changes
Sep 16, 2019
| }; | ||
|
|
||
| get = (id?: string) => { | ||
| get = (id?: string | null) => { |
Contributor
There was a problem hiding this comment.
id? already allows this not to be set, why do we need null ?
…lizozom/kibana into newplatform/data-plugin/remove-kfetch-2
7 tasks
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #44377
kfetchdependency oncore.httpserviceIndexPatternsProviderChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers