[Reporting] Ensure Chromium is always launched with args to create chrome_debug.log#45479
Merged
tsullivan merged 6 commits intoelastic:masterfrom Sep 23, 2019
Merged
Conversation
tsullivan
added
review
zDeprecated Feature:Reporting
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
joelgriffith
approved these changes
Sep 23, 2019
Contributor
joelgriffith
left a comment
joelgriffith
left a comment
There was a problem hiding this comment.
Looks good, will be a lot better to have these logs always.
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 23, 2019
…rome_debug.log (elastic#45479) * remove isVerbose from logger object * Remove verboseLogging from chromium args * fix typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #45214
Unfortunately when Reporting launches Chromium to run a screenshot job, it does not include the arguments to append verbose logs to
chrome_debug.log. Enabling verbose logging in Kibana config would not address it.Fortunately, there always would be a
chrome_debugfile created when Kibana starts up, and verbose logs would be appended to it, because of the self-check at startup. The self-check hardcoded the verbose logging flags in the launch args.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibility