[Reporting/Typescript] Fix types for JobParamsPDF, BrowserConfig, ChromiumDriverFactory#45209
Merged
tsullivan merged 8 commits intoelastic:masterfrom Sep 13, 2019
Merged
Conversation
tsullivan
added
chore
zDeprecated Feature:Reporting
tsullivan
force-pushed
the
reporting/pdf-params-type-fix
branch
from
fc05794 to
961ce14
Compare
tsullivan
commented
Sep 9, 2019
| flags.push('--no-sandbox'); | ||
| } | ||
|
|
||
| // TODO remove conditional |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
tsullivan
commented
Sep 13, 2019
| server: string; | ||
| bypass?: string[]; | ||
| }; | ||
| verboseLogging?: boolean; |
| import { LevelLogger } from '../lib/level_logger'; | ||
| import { KbnServer } from '../../types'; | ||
| import { PLUGIN_ID } from '../../common/constants'; | ||
| import { HeadlessChromiumDriverFactory } from './chromium/driver_factory'; |
Contributor
There was a problem hiding this comment.
Unrelated: I've been thinking we might want to reuse this factory, potentially, for scheduled reports. Not sure about your thoughts on that.
Member
Author
There was a problem hiding this comment.
++ this is one of the guts that we can reuse, as it's not specific to scheduling
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 13, 2019
…omiumDriverFactory (elastic#45209) * [Reporting] Correct PDF Params type definition * Fix types for BrowserConfig, ChromiumDriverFactory * remove jobparams type * spot fixes * fix guard in compat shim * fix legacy functional test * fix jest test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #42421
This change provides type definition fixes for a few types that have been brought in for Typescript conversion of Reporting. The changes here are related to Typescriptification happening since 7.4.0 development.
Addresses: