[IM] update close/delete system index modals#45037
Merged
alisonelizabeth merged 2 commits intoelastic:masterfrom Sep 10, 2019
Merged
[IM] update close/delete system index modals#45037alisonelizabeth merged 2 commits intoelastic:masterfrom
alisonelizabeth merged 2 commits intoelastic:masterfrom
Conversation
alisonelizabeth
added
Feature:Index Management
Contributor
|
Pinging @elastic/es-ui |
alisonelizabeth
commented
Sep 6, 2019
| id="xpack.idxMgmt.indexActionsMenu.deleteIndex.proceedWithCautionCallOutDescription" | ||
| defaultMessage="System indices are critical for internal operations. | ||
| Deleting an index cannot be undone. Make sure you have appropriate backups." | ||
| If you delete a system index, you can't recover it. Make sure you have appropriate backups." |
Contributor
Author
There was a problem hiding this comment.
Text change was suggested by gail while working on the index templates UI
Contributor
💚 Build Succeeded |
sebelga
approved these changes
Sep 10, 2019
Contributor
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
LGTM! Did not test locally.
Contributor
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 10, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...
alisonelizabeth
added a commit
that referenced
this pull request
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the delete/close system index modals to use a badge to denote system indices. This aligns with the index templates UI.
Fixes #45028