[Graph] Re-enable functional test by flash1293 · Pull Request #44683 · elastic/kibana

flash1293 · 2019-09-03T16:50:51Z

Summary

Depends on #44261

Re-enables functional tests for Graph. There were some problems outlined in the issue with testing the shown nodes and edges because the layouting algorithm is not deterministic.

This PR tries to work around these issues and resolves breakages to have coverage for the happy path. This is expected to be temporary solution, because the workspace will be refactored soon (see #44225) and I will make sure to make the visualization accessible which will also simplify functional tests.

Changes:

Match nodes and edges by their x/y positions. To do so, stop the layout before fetching all the elements and matching them up (assigning a source and a target to each edge element)
Clicking an edge is difficult because it can be shadowed by a lot of other stuff. This is solved by removing all nodes but source and target node, then stopping the layout and clicking the center of the line element
When comparing line widths, take an epsilon into account to be robust with regard to floating point issues
Don't validate the geometry of the venn diagram, the values from the labels are sufficient IMHO - the venn diagram rendering logic can be covered by unit tests (also on the roadmap issue [Meta] Graph Technical Plan #44225)

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-05T18:03:09Z

Pinging @elastic/kibana-app

elasticmachine · 2019-09-05T19:26:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

flash1293 · 2019-09-05T19:30:17Z

Seems like clicking the edge is not stable yet - I will look into this.

flash1293 · 2019-09-06T08:22:14Z

OK, selecting the edge should be stable now - ran it ~20 times locally without failures.

elasticmachine · 2019-09-06T09:38:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-06T11:11:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

kertal

just a quick have-a-good-weekend review, started the tests 10x, all passing, look at the details on monday

LeeDr

I haven't pulled this PR yet to run it yet. Just wanted to see if you considered this approach vs hiding the other nodes.

x-pack/test/functional/apps/graph/graph.ts

…test

elasticmachine · 2019-09-09T08:35:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

kertal

Code LGTM, run the tests several times, no problems, here's the award for no-flakiness 🥇

x-pack/test/functional/page_objects/graph_page.ts

elasticmachine · 2019-09-09T14:54:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

LeeDr

LGTM - I pulled and ran it locally. Looks good!

…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...

flash1293 added 30 commits August 26, 2019 17:56

create graph listing page

067158a

clean up app folder

5fddc10

remove inline loading menu

95f003b

also add badge to workspace route

ae44388

fix tests

2f1056f

fix graph spaces functional test

5d637f5

generate documentation for new breadcrumb property

9d17862

fix test subject names

db1d740

remove unused translations

e09b70d

start implementing save modal flow for Graph

2dab994

fix spaces functional test

c34d845

wip save modal

2d775e6

wip save modal

ebe80d1

add and style save modal

fab1577

add placeholder to description field

a9d31c8

Merge remote-tracking branch 'upstream/master' into graph/listing-page

9d2822e

Merge remote-tracking branch 'upstream/master' into graph/listing-page

d0b9247

disable dirty check on breadcrumb navigation and fix delete function

d187eae

Merge branch 'graph/listing-page' into graph/savemodal

21ba056

improve onClick typing on breadcrumb

a289d7d

Merge branch 'graph/listing-page' into graph/savemodal

989481c

fix newline error and use new types in dashboard app controller

be1e59a

fix translation errors

c5ac49b

fix i18n translation for real

8d6cec1

Merge remote-tracking branch 'upstream/master' into graph/savemodal

0472505

code review

173804a

Merge remote-tracking branch 'upstream/master' into graph/savemodal

54e9a7b

fix i18n phrases

6f1bbca

remove fragments

7c94337

fix graph functional tests wip

7c0e664

flash1293 requested review from LeeDr and kertal and removed request for a team September 5, 2019 18:02

flash1293 added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.5.0 v8.0.0 labels Sep 5, 2019

stabilize edge selection

8cfc834

remove unused import

b024bc8

kertal reviewed Sep 6, 2019

View reviewed changes

LeeDr reviewed Sep 6, 2019

View reviewed changes

x-pack/test/functional/apps/graph/graph.ts Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into graph/functional-…

c282064

…test

kertal approved these changes Sep 9, 2019

View reviewed changes

x-pack/test/functional/page_objects/graph_page.ts Outdated Show resolved Hide resolved

remove unused function

48b8763

LeeDr approved these changes Sep 9, 2019

View reviewed changes

flash1293 merged commit c46eea5 into elastic:master Sep 10, 2019

flash1293 deleted the graph/functional-test branch September 10, 2019 08:20

flash1293 added a commit to flash1293/kibana that referenced this pull request Sep 10, 2019

[Graph] Re-enable functional test (elastic#44683)

cc65300

flash1293 mentioned this pull request Sep 10, 2019

[7.x] [Graph] Re-enable functional test (#44683) #45239

Merged

flash1293 added a commit that referenced this pull request Sep 10, 2019

[Graph] Re-enable functional test (#44683) (#45239)

32c178e

Conversation

flash1293 commented Sep 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 5, 2019

Uh oh!

elasticmachine commented Sep 5, 2019

💔 Build Failed

Uh oh!

flash1293 commented Sep 5, 2019

Uh oh!

flash1293 commented Sep 6, 2019

Uh oh!

elasticmachine commented Sep 6, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 6, 2019

💚 Build Succeeded

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Sep 9, 2019

💚 Build Succeeded

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Sep 9, 2019

💚 Build Succeeded

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flash1293 commented Sep 3, 2019 •

edited

Loading