[ML] Data Frames: Analytics job creation.#43102
Merged
walterra merged 7 commits intoelastic:masterfrom Aug 13, 2019
Merged
Conversation
walterra
added
release_note:enhancement
:ml
v8.0.0
v7.4.0
Feature:Data Frame Analytics
walterra
requested review from
alvarezmelissa87,
jgowdyelastic and
peteharverson
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
alvarezmelissa87
approved these changes
Aug 12, 2019
Contributor
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Gave this a test locally and seemed to work as expected. LGTM ⚡️
jgowdyelastic
approved these changes
Aug 13, 2019
Member
jgowdyelastic
left a comment
jgowdyelastic
left a comment
There was a problem hiding this comment.
Added a couple of comments but on the whole LGTM
| return state; | ||
| }; | ||
|
|
||
| enum ACTION { |
Member
There was a problem hiding this comment.
it looks like this could be a normal numerical enum, e.g.
enum ACTION {
ADD_REQUEST_MESSAGE,
RESET_REQUEST_MESSAGES,
....
| } | ||
|
|
||
| // List of system fields we want to ignore for the numeric field check. | ||
| const OMIT_FIELDS: string[] = ['_source', '_type', '_index', '_id', '_version', '_score']; |
Member
There was a problem hiding this comment.
this could be moved to a shared location along with the copy in datavisualizer
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 13, 2019
Introduces data frame analytics job creation. This first version uses a form within a modal on the analytics jobs list page, because there is no preview available and the form isn't very complex. Job creation might move to a separate page in the future.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 13, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...
walterra
added a commit
that referenced
this pull request
Aug 13, 2019
Introduces data frame analytics job creation. This first version uses a form within a modal on the analytics jobs list page, because there is no preview available and the form isn't very complex. Job creation might move to a separate page in the future.
This was referenced Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #43175.
Summary
Introduces data frame analytics job creation. This first version uses a form within a modal on the analytics jobs list page, because there is no preview available and the form isn't very complex. Job creation might move to a separate page in the future.
useReducer()in a custom hook (see React Docs. The custom hookuseCreateAnalyticsForm()exposes the current state and actions needed by the UI. This way the componentsCreateAnalyticsForm,CreateAnalyticsModalandCreateAnalyticsButtonare not aware of any state logic, they just consume a state and trigger actions.Note this PR doesn't include any unit tests yet. The feature is experimental and tests will be done in a follow up.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers