[Maps] Enable borders for icon symbols#43066
Conversation
nickpeihl
added
release_note:enhancement
Team:Geo
|
Pinging @elastic/kibana-gis |
💚 Build Succeeded |
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
Adding borders to icons looks great and really highlights all of the icon details. Thanks for putting this PR together.
Can you also update the docs, https://github.com/elastic/kibana/blob/master/docs/maps/vector-style-properties.asciidoc, adding Border color and Border width to the icon section?
| componentDidMount() { | ||
| this._isMounted = true; | ||
| this._loadSymbol(this.props.symbolId, this.props.fill); | ||
| this._loadSymbol(this.props.symbolId, this.props.fill, this.props.stroke, this.props.strokeWidth); |
There was a problem hiding this comment.
Update SymbolIcon.propTypes definition at end of file to include stroke and strokeWidth
| </Fragment> | ||
| ); | ||
| } else { | ||
| const lineColor = ( |
There was a problem hiding this comment.
Since lineColor and lineWidth are now constant, their definition can just be moved directly into the return block and lineColor and lineWidth variables are no longer needed.
| <EuiSpacer size="m" /> | ||
|
|
||
| {lineColor} | ||
| <Fragment> |
There was a problem hiding this comment.
Fragment wrapper is not needed here
| </Fragment> | ||
|
|
||
| {lineWidth} | ||
| <Fragment> |
There was a problem hiding this comment.
Fragment wrapper is not needed here
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm with green CI
code review, tested in chrome
💚 Build Succeeded |
* [Maps] Enable borders on icons * [Maps] Enable borders on icons * Review feedback * Remove unnecessary Fragment
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...
3 participants
Fixes #42949. This extends the Border Width and Border Color options for icon symbols in the Maps app.