Skip to content

[Lens] Add some tests around document handling in dimension panel #42670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flash1293 merged 2 commits into from
Aug 7, 2019
Merged

[Lens] Add some tests around document handling in dimension panel #42670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2036188
add some tests around document handling
flash1293 Aug 6, 2019
db2533d
dimension panel: put incompatibility information in data-test-subj
flash1293 Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
202 changes: 176 additions & 26 deletions ...k/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/dimension_panel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,14 @@ describe('IndexPatternDimensionPanel', () => {

const options = wrapper.find(EuiComboBox).prop('options');

expect(options![0].className).toContain('incompatible');
expect(options![0]['data-test-subj']).toEqual('lns-documentOptionIncompatible');

expect(
options![1].options!.filter(({ label }) => label === 'timestamp')[0].className
).toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'timestamp')[0]['data-test-subj']
).toContain('Incompatible');
expect(
options![1].options!.filter(({ label }) => label === 'memory')[0].className
).not.toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'memory')[0]['data-test-subj']
).not.toContain('Incompatible');
});

it('should indicate operations which are incompatible for the field of the current column', () => {
Expand Down Expand Up @@ -260,12 +260,15 @@ describe('IndexPatternDimensionPanel', () => {
const options = (wrapper.find(EuiSideNav).prop('items')[0].items as unknown) as Array<{
name: string;
className: string;
'data-test-subj': string;
}>;

expect(options.find(({ name }) => name === 'Minimum')!.className).not.toContain('incompatible');
expect(options.find(({ name }) => name === 'Minimum')!['data-test-subj']).not.toContain(
'Incompatible'
);

expect(options.find(({ name }) => name === 'Date Histogram')!.className).toContain(
'incompatible'
expect(options.find(({ name }) => name === 'Date Histogram')!['data-test-subj']).toContain(
'Incompatible'
);
});

Expand Down Expand Up @@ -450,7 +453,9 @@ describe('IndexPatternDimensionPanel', () => {
openPopover();

act(() => {
wrapper.find('button[data-test-subj="lns-indexPatternDimension-terms"]').simulate('click');
wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');
});

expect(setState).not.toHaveBeenCalled();
Expand All @@ -461,7 +466,9 @@ describe('IndexPatternDimensionPanel', () => {

openPopover();

wrapper.find('button[data-test-subj="lns-indexPatternDimension-terms"]').simulate('click');
wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');

expect(wrapper.find('[data-test-subj="indexPattern-invalid-operation"]')).not.toHaveLength(0);

Expand All @@ -473,7 +480,9 @@ describe('IndexPatternDimensionPanel', () => {

openPopover();

wrapper.find('button[data-test-subj="lns-indexPatternDimension-terms"]').simulate('click');
wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');

wrapper
.find('button[data-test-subj="lns-indexPatternDimension-date_histogram"]')
Expand All @@ -487,7 +496,9 @@ describe('IndexPatternDimensionPanel', () => {

openPopover();

wrapper.find('button[data-test-subj="lns-indexPatternDimension-terms"]').simulate('click');
wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');

act(() => {
wrapper.find(EuiPopover).prop('closePopover')!();
Expand All @@ -503,18 +514,97 @@ describe('IndexPatternDimensionPanel', () => {

openPopover();

wrapper.find('button[data-test-subj="lns-indexPatternDimension-terms"]').simulate('click');
wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');

const options = wrapper.find(EuiComboBox).prop('options');

expect(options![0].className).toContain('incompatible');
expect(options![0]['data-test-subj']).toContain('Incompatible');

expect(
options![1].options!.filter(({ label }) => label === 'timestamp')[0].className
).toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'timestamp')[0]['data-test-subj']
).toContain('Incompatible');
expect(
options![1].options!.filter(({ label }) => label === 'source')[0].className
).not.toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'source')[0]['data-test-subj']
).not.toContain('Incompatible');
});

it('should indicate document compatibility with selected field operation', () => {
const initialState: IndexPatternPrivateState = {
...state,
layers: {
first: {
...state.layers.first,
columns: {
...state.layers.first.columns,
col2: {
dataType: 'number',
isBucketed: false,
label: '',
operationType: 'avg',
sourceField: 'bytes',
},
},
},
},
};
wrapper = mount(
<IndexPatternDimensionPanel {...defaultProps} state={initialState} columnId="col2" />
);

openPopover();

wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-count"]')
.simulate('click');

const options = wrapper.find(EuiComboBox).prop('options');

expect(options![0]['data-test-subj']).not.toContain('Incompatible');
options![1].options!.map(option =>
expect(option['data-test-subj']).toContain('Incompatible')
);
});

it('should indicate document and field compatibility with selected document operation', () => {
const initialState: IndexPatternPrivateState = {
...state,
layers: {
first: {
...state.layers.first,
columns: {
...state.layers.first.columns,
col2: {
dataType: 'number',
isBucketed: false,
label: '',
operationType: 'count',
},
},
},
},
};
wrapper = mount(
<IndexPatternDimensionPanel {...defaultProps} state={initialState} columnId="col2" />
);

openPopover();

wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');

const options = wrapper.find(EuiComboBox).prop('options');

expect(options![0]['data-test-subj']).toContain('Incompatible');

expect(
options![1].options!.filter(({ label }) => label === 'timestamp')[0]['data-test-subj']
).toContain('Incompatible');
expect(
options![1].options!.filter(({ label }) => label === 'source')[0]['data-test-subj']
).not.toContain('Incompatible');
});

it('should set datasource state if compatible field is selected for operation', () => {
Expand All @@ -523,7 +613,9 @@ describe('IndexPatternDimensionPanel', () => {
openPopover();

act(() => {
wrapper.find('button[data-test-subj="lns-indexPatternDimension-terms"]').simulate('click');
wrapper
.find('button[data-test-subj="lns-indexPatternDimensionIncompatible-terms"]')
.simulate('click');
});

const comboBox = wrapper.find(EuiComboBox)!;
Expand Down Expand Up @@ -622,6 +714,31 @@ describe('IndexPatternDimensionPanel', () => {
});
});

it('should select operation directly if only document is possible', () => {
wrapper = mount(<IndexPatternDimensionPanel {...defaultProps} columnId={'col2'} />);

openPopover();

wrapper.find('button[data-test-subj="lns-indexPatternDimension-count"]').simulate('click');

expect(setState).toHaveBeenCalledWith({
...state,
layers: {
first: {
...state.layers.first,
columns: {
...state.layers.first.columns,
col2: expect.objectContaining({
operationType: 'count',
// Other parts of this don't matter for this test
}),
},
columnOrder: ['col1', 'col2'],
},
},
});
});

it('should indicate compatible fields when selecting the operation first', () => {
wrapper = mount(<IndexPatternDimensionPanel {...defaultProps} columnId={'col2'} />);

Expand All @@ -631,17 +748,50 @@ describe('IndexPatternDimensionPanel', () => {

const options = wrapper.find(EuiComboBox).prop('options');

expect(options![0].className).toContain('incompatible');
expect(options![0]['data-test-subj']).toContain('Incompatible');

expect(
options![1].options!.filter(({ label }) => label === 'timestamp')[0].className
).toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'timestamp')[0]['data-test-subj']
).toContain('Incompatible');
expect(
options![1].options!.filter(({ label }) => label === 'bytes')[0].className
).not.toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'bytes')[0]['data-test-subj']
).not.toContain('Incompatible');
expect(
options![1].options!.filter(({ label }) => label === 'memory')[0].className
).not.toContain('incompatible');
options![1].options!.filter(({ label }) => label === 'memory')[0]['data-test-subj']
).not.toContain('Incompatible');
});

it('should indicate document compatibility when document operation is selected', () => {
const initialState: IndexPatternPrivateState = {
...state,
layers: {
first: {
...state.layers.first,
columns: {
...state.layers.first.columns,
col2: {
dataType: 'number',
isBucketed: false,
label: '',
operationType: 'count',
},
},
},
},
};
wrapper = mount(
<IndexPatternDimensionPanel {...defaultProps} state={initialState} columnId={'col2'} />
);

openPopover();

const options = wrapper.find(EuiComboBox).prop('options');

expect(options![0]['data-test-subj']).not.toContain('Incompatible');

options![1].options!.map(operation =>
expect(operation['data-test-subj']).toContain('Incompatible')
);
});

it('should show all operations that are not filtered out', () => {
Expand Down
4 changes: 4 additions & 0 deletions x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/field_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ export function FieldSelect({
className: classNames({
'lnsConfigPanel__fieldOption--incompatible': !isCurrentOperationApplicableWithoutField,
}),
'data-test-subj': `lns-documentOption${
isCurrentOperationApplicableWithoutField ? '' : 'Incompatible'
}`,
});
}

Expand Down Expand Up @@ -109,6 +112,7 @@ export function FieldSelect({
label,
value,
className: classNames({ 'lnsConfigPanel__fieldOption--incompatible': !compatible }),
'data-test-subj': `lns-fieldOption${compatible ? '' : 'Incompatible'}-${label}`,
})),
});
}
Expand Down
4 changes: 3 additions & 1 deletion x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/popover_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ export function PopoverEditor(props: PopoverEditorProps) {
),
'lnsConfigPanel__operation--incompatible': !compatibleWithCurrentField,
}),
'data-test-subj': `lns-indexPatternDimension-${operationType}`,
'data-test-subj': `lns-indexPatternDimension${
compatibleWithCurrentField ? '' : 'Incompatible'
}-${operationType}`,
onClick() {
if (!selectedColumn) {
const possibleFields = fieldByOperation[operationType] || [];
Expand Down