Inspector -> New Platform

.i18nrc.json

@@ -24,7 +24,8 @@
     "timelion": "src/legacy/core_plugins/timelion",
     "tagCloud": "src/legacy/core_plugins/tagcloud",
     "tsvb": "src/legacy/core_plugins/metrics",
-    "kbnESQuery": "packages/kbn-es-query"
+    "kbnESQuery": "packages/kbn-es-query",
+    "plugins": "src/plugins"
   },
   "exclude": ["src/legacy/ui/ui_render/ui_render_mixin.js"],
   "translations": []

src/legacy/core_plugins/dashboard_embeddable_container/public/np_core.test.mocks.ts

@@ -17,35 +17,11 @@
  * under the License.
  */
 
-import { fatalErrorsServiceMock, notificationServiceMock } from '../../../../core/public/mocks';
-
 let modalContents: React.Component;
 
 export const getModalContents = () => modalContents;
 
-jest.doMock('ui/new_platform', () => {
-  return {
-    npStart: {
-      core: {
-        overlays: {
-          openFlyout: jest.fn(),
-          openModal: (component: React.Component) => {
-            modalContents = component;
-            return {
-              close: jest.fn(),
-            };
-          },
-        },
-      },
-    },
-    npSetup: {
-      core: {
-        fatalErrors: fatalErrorsServiceMock.createSetupContract(),
-        notifications: notificationServiceMock.createSetupContract(),
-      },
-    },
-  };
-});
+jest.mock('ui/new_platform');
 
 jest.doMock('ui/metadata', () => ({
   metadata: {

src/legacy/core_plugins/embeddable_api/public/ui_capabilities.test.mocks.ts

@@ -24,3 +24,5 @@ jest.doMock('ui/capabilities', () => ({
     },
   },
 }));
+
+jest.mock('ui/new_platform');

src/legacy/core_plugins/inspector_views/public/data/data_view.test.js

@@ -22,6 +22,7 @@ import { DataView } from './data_view';
 import { DataAdapter } from 'ui/inspector/adapters';
 import { mountWithIntl } from 'test_utils/enzyme_helpers';
 
+jest.mock('ui/new_platform');
 jest.mock('./lib/export_csv', () => ({
   exportAsCsv: jest.fn(),
 }));

src/legacy/core_plugins/kibana/public/dashboard/migrations/migrate_to_730_panels.test.ts

@@ -34,6 +34,8 @@ jest.mock(
   { virtual: true }
 );
 
+jest.mock('ui/new_platform');
+
 import { migratePanelsTo730 } from './migrate_to_730_panels';
 import { SavedDashboardPanelTo60, SavedDashboardPanel730ToLatest } from '../types';
 import {

src/legacy/core_plugins/kibana/public/dashboard/np_core.test.mocks.ts

@@ -17,35 +17,11 @@
  * under the License.
  */
 
-import { fatalErrorsServiceMock, notificationServiceMock } from '../../../../../core/public/mocks';
-
 let modalContents: React.Component;
 
 export const getModalContents = () => modalContents;
 
-jest.doMock('ui/new_platform', () => {
-  return {
-    npStart: {
-      core: {
-        overlays: {
-          openFlyout: jest.fn(),
-          openModal: (component: React.Component) => {
-            modalContents = component;
-            return {
-              close: jest.fn(),
-            };
-          },
-        },
-      },
-    },
-    npSetup: {
-      core: {
-        fatalErrors: fatalErrorsServiceMock.createSetupContract(),
-        notifications: notificationServiceMock.createSetupContract(),
-      },
-    },
-  };
-});
+jest.mock('ui/new_platform');
 
 jest.doMock('ui/metadata', () => ({
   metadata: {

src/legacy/core_plugins/tests_bundle/index.js

@@ -104,11 +104,14 @@ export default (kibana) => {
           modules: [...modules],
           template: createTestEntryTemplate(uiSettingDefaults),
           extendConfig(webpackConfig) {
-            return webpackMerge({
+            const mergedConfig = webpackMerge({
               resolve: {
                 extensions: ['.karma_mock.js', '.karma_mock.tsx', '.karma_mock.ts']
               }
             }, webpackConfig);
+            delete mergedConfig.optimization.splitChunks.cacheGroups.commons;
+
+            return mergedConfig;
           }
         });
 

src/legacy/ui/public/_index.scss

@@ -18,7 +18,6 @@
 @import './error_url_overflow/index';
 @import './exit_full_screen/index';
 @import './field_editor/index';
-@import './inspector/index';
 @import './kbn_top_nav/index';
 @import './markdown/index';
 @import './notify/index';

src/legacy/ui/public/inspector/README.md

@@ -1,127 +1,6 @@
 # Inspector
 
-The inspector is a contextual tool to gain insights into different elements
-in Kibana, e.g. visualizations. It has the form of a flyout panel.
-
-## Inspector Views
-
-The "Inspector Panel" can have multiple so called "Inspector Views" inside of it.
-These views are used to gain different information into the element you are inspecting.
-There is a request inspector view to gain information in the requests done for this
-element or a data inspector view to inspect the underlying data. Whether or not
-a specific view is available depends on the used adapters.
-
-## Inspector Adapters
-
-Since the Inspector panel itself is not tied to a specific type of elements (visualizations,
-saved searches, etc.), everything you need to open the inspector is a collection
-of so called inspector adapters. A single adapter can be any type of JavaScript class.
-
-Most likely an adapter offers some kind of logging capabilities for the element, that
-uses it e.g. the request adapter allows element (like visualizations) to log requests
-they make.
-
-The corresponding inspector view will then use the information inside the adapter
-to present the data in the panel. That concept allows different types of elements
-to use the Inspector panel, while they can use completely or partial different adapters
-and inspector views than other elements.
-
-For example a visualization could provide the request and data adapter while a saved
-search could only provide the request adapter and a Vega visualization could additionally
-provide a Vega adapter.
-
-There is no 1 to 1 relationship between adapters and views. An adapter could be used
-by multiple views and a view can use data from multiple adapters. It's up to the
-view to decide whether or not it wants to be shown for a given adapters list.
-
-## Develop custom inspectors
-
-You can extend the inspector panel by adding custom inspector views and inspector
-adapters via a plugin.
-
-### Develop inspector views
-
-To develop custom inspector views you should first register your file via `uiExports`
-in your plugin config:
-
-```js
-export default (kibana) => {
-  return new kibana.Plugin({
-    uiExports: {
-      inspectorViews: [ 'plugins/your_plugin/custom_view' ],
-    }
-  });
-};
-```
-
-Within the `custom_view.js` file in your `public` folder, you can define your
-inspector view as follows:
-
-```js
-import React from 'react';
-import { InspectorView, viewRegistry } from 'ui/inspector';
-
-function MyInspectorComponent(props) {
-  // props.adapters is the object of all adapters and may vary depending
-  // on who and where this inspector was opened. You should check for all
-  // adapters you need, in the below shouldShow method, before accessing
-  // them here.
-  return (
-    <InspectorView>
-      { /* Always use InspectorView as the wrapping element! */ }
-    </InspectorView>
-  );
-}
-
-const MyLittleInspectorView = {
-  // Title shown to select this view
-  title: 'Display Name',
-  // An icon id from the EUI icon list
-  icon: 'iconName',
-  // An order to sort the views (lower means first)
-  order: 10,
-  // An additional helptext, that wil
-  help: `And additional help text, that will be shown in the inspector help.`,
-  shouldShow(adapters) {
-    // Only show if `someAdapter` is available. Make sure to check for
-    // all adapters that you want to access in your view later on and
-    // any additional condition you want to be true to be shown.
-    return adapters.someAdapter;
-  },
-  // A React component, that will be used for rendering
-  component: MyInspectorComponent
-};
-
-viewRegistry.register(MyLittleInspectorView);
-```
-
-### Develop custom adapters
-
-An inspector adapter is just a plain JavaScript class, that can e.g. be attached
-to custom visualization types, so an inspector view can show additional information for this
-visualization.
-
-To add additional adapters to your visualization type, use the `inspectorAdapters.custom`
-object when defining the visualization type:
-
-```js
-class MyCustomInspectorAdapter {
-  // ....
-}
-
-// inside your visualization type description (usually passed to VisFactory.create...Type)
-{
-  // ...
-  inspectorAdapters: {
-    custom: {
-      someAdapter: MyCustomInspectorAdapter
-    }
-  }
-}
-```
-
-An instance of MyCustomInspectorAdapter will now be available on each visualization
-of that type and can be accessed via `vis.API.inspectorAdapters.someInspector`.
-
-Custom inspector views can now check for the presence of `adapters.someAdapter`
-in their `shouldShow` method and use this adapter in their component.
+- Inspector has been moved to `inspector` New Platform plugin.
+- You can find its documentation in `src/plugins/inspector/README.md`.
+- This folder will be deleted soon, it is deprecated, do not use anything from here.
+- This folder is ready to be deleted, as soon as nothing imports from here anymore.

src/legacy/ui/public/inspector/adapters/index.ts

@@ -17,5 +17,11 @@
  * under the License.
  */
 
-export { DataAdapter, FormattedData } from './data';
-export { RequestAdapter, RequestStatus } from './request';
+/* eslint-disable */
+
+/**
+ * Do not use this, use NP `inspector` plugin instead.
+ * 
+ * @deprecated
+ */
+export * from '../../../../../plugins/inspector/public/adapters/index';