Inspector -> New Platform #42164

streamich · 2019-07-29T16:17:36Z

Summary

TypeScript-ifies remaining .js in Inspector.
Moves Inspector to a real inspector New Platform plugin.
Old inspector folder in ui/public still works as before.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Dev Docs

Inspector 👉 New Platform `inspector` plugin

Inspector ui-public module has been moved to a New Platform plugin.
You can find its documentation in src/plugins/inspector/README.md.
Old Inspector module still works as before, but all methods are now marked as deprecated. During one of upcoming 7.x releases it will be completely deleted.

If you need to use inspector plugin from within src/legacy location, use New Platform plugin backdoor.

import { npSetup, npStart } from 'ui/new_platform';

npSetup.plugins.inspector.registerView(view);

npStart.plugins.inspector.isAvailable(adapters);
npStart.plugins.inspector.open( /* ... */ );

elasticmachine · 2019-07-29T16:22:00Z

Pinging @elastic/kibana-app-arch

src/legacy/ui/public/inspector/ui/inspector_view.tsx

stacey-gammon

Code looks good, pulled down and tested. LGTM pending sass comment response and green ci. 🎉

.i18nrc.json

src/legacy/core_plugins/tests_bundle/index.js

src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

src/legacy/ui/public/inspector/view_registry.ts

src/plugins/inspector/public/plugin.tsx

Co-Authored-By: Stacey Gammon <[email protected]>

…ontext-providers' into ui-inspector-to-np

Co-Authored-By: Stacey Gammon <[email protected]>

…ector-to-np

src/plugins/inspector/public/ui/inspector_panel.tsx

elasticmachine · 2019-08-02T14:57:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* refactor: 💡 remove SASS and clean up InspectorView component * refactor: 💡 clean up inspector, convert .js -> .ts * feat: 🎸 add Inspector NP plugin boilerplate * feat: 🎸 move view registry to NP, move types, add registerView * docs: ✏️ move inspector README to NP plugin * refactor: 💡 move ui/inspector/ui to NP * refactor: 💡 move Inspector adapters to NP * refactor: 💡 move Inspector.isAvailable to New Platform * refactor: 💡 move Inspector.open to New Platform plugin * test: 💍 move Inspector tests to NP plugin * chore: 🤖 fix imports * feat: 🎸 update translations * test: 💍 fix failing translation snapshot * test: 💍 fix yarn test:browser tests * Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts Co-Authored-By: Stacey Gammon <[email protected]> * [ML] [Job wizards] switching to new kibana context provider * fix: 🐛 specify translation path directly to the plugin * docs: ✏️ add comment about Webpack config fix * Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts Co-Authored-By: Stacey Gammon <[email protected]> * Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts Co-Authored-By: Stacey Gammon <[email protected]> * feat: 🎸 improve types as per review * fix: 🐛 remove <InspectorView> comp and fix view layouts * test: 💍 improve mocks

…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

elasticmachine · 2019-08-28T12:16:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

streamich requested a review from a team as a code owner July 29, 2019 16:17

streamich added Feature:Inspector Inspector infrastructure and implementations Feature:New Platform release_note:deprecation release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review Team:AppArch v7.4.0 v8.0.0 labels Jul 29, 2019

streamich requested review from ppisljar and stacey-gammon July 29, 2019 16:22

cchaos reviewed Jul 29, 2019

View reviewed changes

src/legacy/ui/public/inspector/ui/inspector_view.tsx Outdated Show resolved Hide resolved

elastic deleted a comment from elasticmachine Jul 29, 2019

streamich added 14 commits July 30, 2019 18:35

refactor: 💡 remove SASS and clean up InspectorView component

5996835

refactor: 💡 clean up inspector, convert .js -> .ts

78e1fde

feat: 🎸 add Inspector NP plugin boilerplate

6766866

feat: 🎸 move view registry to NP, move types, add registerView

c0b40fa

docs: ✏️ move inspector README to NP plugin

f02deff

refactor: 💡 move ui/inspector/ui to NP

055f37c

refactor: 💡 move Inspector adapters to NP

49ce4d1

refactor: 💡 move Inspector.isAvailable to New Platform

d4d86b7

refactor: 💡 move Inspector.open to New Platform plugin

53fc00d

test: 💍 move Inspector tests to NP plugin

d626647

chore: 🤖 fix imports

6e1cd4d

feat: 🎸 update translations

8974d0f

test: 💍 fix failing translation snapshot

1074e14

test: 💍 fix yarn test:browser tests

328d7a6

elastic deleted a comment from elasticmachine Jul 30, 2019

stacey-gammon approved these changes Jul 31, 2019

View reviewed changes

streamich and others added 8 commits July 31, 2019 19:06

Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

e40b153

Co-Authored-By: Stacey Gammon <[email protected]>

[ML] [Job wizards] switching to new kibana context provider

151a0e6

Merge remote-tracking branch 'upstream/master' into ui-inspector-to-np

74472ce

Merge remote-tracking branch 'jgowdyelastic/switching-to-new-kibana-c…

af75060

…ontext-providers' into ui-inspector-to-np

fix: 🐛 specify translation path directly to the plugin

7263157

docs: ✏️ add comment about Webpack config fix

4ea86b6

Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

a6dda9e

Co-Authored-By: Stacey Gammon <[email protected]>

Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

41ae462

Co-Authored-By: Stacey Gammon <[email protected]>

elastic deleted a comment from elasticmachine Aug 2, 2019

streamich added 3 commits August 2, 2019 12:06

feat: 🎸 improve types as per review

a4e4596

Merge remote-tracking branch 'origin/ui-inspector-to-np' into ui-insp…

d5fea29

…ector-to-np

fix: 🐛 remove <InspectorView> comp and fix view layouts

e63259f

elastic deleted a comment from elasticmachine Aug 2, 2019

streamich added 2 commits August 2, 2019 15:40

test: 💍 improve mocks

6daa23b

Merge remote-tracking branch 'upstream/master' into ui-inspector-to-np

3867bca

cchaos approved these changes Aug 2, 2019

View reviewed changes

src/plugins/inspector/public/ui/inspector_panel.tsx Show resolved Hide resolved

streamich merged commit 39b233a into elastic:master Aug 2, 2019

streamich deleted the ui-inspector-to-np branch August 2, 2019 15:00

streamich mentioned this pull request Aug 2, 2019

[7.x] Inspector 👉 New Platform (#42164) #42530

Merged

lukeelmers mentioned this pull request Aug 5, 2019

App Architecture roadmap for New Platform migration #31968

Closed

lukeelmers added Feature:NP Migration and removed Feature:New Platform labels Aug 5, 2019

lukeelmers mentioned this pull request Aug 5, 2019

Migrate inspector_views to new platform #42636

Closed

marius-dr changed the title ~~Inspector 👉 New Platform~~ Inspector -> New Platform Aug 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Inspector -> New Platform #42164

Inspector -> New Platform #42164

Uh oh!

streamich commented Jul 29, 2019 •

edited

Loading

Uh oh!

elasticmachine commented Jul 29, 2019

Uh oh!

Uh oh!

stacey-gammon left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 2, 2019

Uh oh!

elasticmachine commented Aug 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Inspector -> New Platform #42164

Inspector -> New Platform #42164

Uh oh!

Conversation

streamich commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Dev Docs

Inspector 👉 New Platform inspector plugin

Uh oh!

elasticmachine commented Jul 29, 2019

Uh oh!

Uh oh!

stacey-gammon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 28, 2019

💔 Build Failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

streamich commented Jul 29, 2019 •

edited

Loading

Inspector 👉 New Platform `inspector` plugin