Use custom GECKODRIVER_CDNURL#41513
Merged
spalger merged 2 commits intoelastic:masterfrom Jul 19, 2019
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations |
spalger
added
release_note:skip
spalger
changed the title
spalger
force-pushed
the
implement/geckodriver-proxy
branch
from
5698d47 to
c05aa39
Compare
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2019
This was referenced Jul 19, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2019
# Conflicts: # .ci/packer_cache.sh # src/dev/ci_setup/setup.sh
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2019
# Conflicts: # .ci/packer_cache.sh # src/dev/ci_setup/setup.sh
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jul 19, 2019
# Conflicts: # .ci/packer_cache.sh # src/dev/ci_setup/setup.sh
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2019
spalger
pushed a commit
that referenced
this pull request
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried submitting a PR to 6.8 and can't get it to run without hitting 500's from github trying to download the geckodriver distributable. This PR uses a simple cloud function to access artifacts that are cached in GCS, the function checks if the object exists, downloads it if necessary, and redirects to the public URL for the artifact.