Console update autocomplete definitions by sebelga · Pull Request #39508 · elastic/kibana

sebelga · 2019-06-24T12:10:13Z

This PR updates the console autocomplete definitions generated with the yarn spec_to_console.

@dimitris-athanasiou Can you please test the payloads for data frame analytics and confirm if the property feature_influence_threshold is correct?

I also made a small modification to the README.md file and updated the yarn script to make sure that the folder exists before trying to write a file into it.

…ing file

elasticmachine · 2019-06-24T12:11:27Z

Pinging @elastic/es-ui

elasticmachine · 2019-06-24T13:15:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2019-06-24T23:31:24Z

@sebelga I took a quick look and I just wanted to double-check that these files all belong in x-pack? Many of these endpoints (e.g. cat health) look like they belong in OSS: https://github.com/elastic/kibana/tree/master/src/legacy/core_plugins/console/api_server/spec/generated.

I also wonder how we define the generated spec files. Should we sync with Bill or re-watch his walkthrough video?

sebelga · 2019-06-25T08:15:01Z

@cjcenizal I never thought we'd spread the generated definition across folders... I will re-watch the walkthrough video to see how to fix this.

EDIT: I figured it out, we indeed need to call the script twice, once for oss and once for xpack. I will now add manually the new APIs body payload

This reverts commit 67ce639.

elasticmachine · 2019-06-25T16:15:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-26T11:52:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-26T16:24:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sebelga · 2019-06-26T16:37:01Z

@jen-huang @alisonelizabeth the PR is ready for review when you have time 😊

elasticmachine · 2019-06-26T17:54:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

alisonelizabeth

LGTM. Tried out the yarn script and tested a couple of the autocomplete changes but not all.

cjcenizal · 2019-06-28T17:04:11Z

@sebelga Take a look at #19928 to refer to the value of manually reviewing and testing these endpoints. It looks like most of the things we caught were either a) errors in the overrides which we could fix in the PR or b) mistakes on the Elasticsearch side which we could forward on to the appropriate owner.

sebelga · 2019-07-01T05:09:07Z

@cjcenizal I see. Do you think it would be valuable to work on a better (less error-prone and no engineering time involved) system? It seems to me that we should have a single source of truth with its tests (probably in the Elasticsearch repo) and all the dependent parties would pull from it without having to retest everything.

cjcenizal · 2019-07-01T12:43:16Z

Do you think it would be valuable to work on a better (less error-prone and no engineering time involved) system? It seems to me that we should have a single source of truth with its tests (probably in the Elasticsearch repo) and all the dependent parties would pull from it without having to retest everything.

100% yes! The vision of what this system would look like isn't clear to me. I'd love to discuss any ideas you have.

cjcenizal · 2019-07-02T01:55:18Z

x-pack/legacy/plugins/console_extensions/spec/overrides/ml.evaluate_data_frame.json

@@ -0,0 +1,24 @@
+{


@dimitris-athanasiou I couldn't find docs for this API online. Do they live somewhere?

EDIT: Same goes for the put_data_frame_analytics API below.

No. We're working on the docs, they should be added this week.

cjcenizal

Code LGTM. I tested the overrides, some documentation links, and a few random endpoints in the browser and everything worked as expected. Thanks for doing this @sebelga!

dimitris-athanasiou

The data frame analytics bits look good to me!

sebelga · 2019-07-02T12:53:40Z

Thanks for the review @dimitris-athanasiou, @alisonelizabeth @cjcenizal!

…tocomplete-definitions

elasticmachine · 2019-07-02T13:50:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sebelga · 2019-07-02T14:02:56Z

retest

sebelga · 2019-07-02T14:12:09Z

retest

elasticmachine · 2019-07-02T15:04:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

alisonelizabeth · 2019-07-02T15:08:59Z

retest

elasticmachine · 2019-07-02T15:15:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-02T16:13:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sebelga added 2 commits June 24, 2019 14:04

Update README.md spec to console + make sure folder exist before writ…

94f0cd0

…ing file

Update generated console autocomplete definitions

67ce639

sebelga requested a review from cjcenizal June 24, 2019 12:10

sebelga added Feature:Console Dev Tools Console Feature release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.3.0 v8.0.0 labels Jun 24, 2019

cjcenizal requested review from alisonelizabeth and jen-huang and removed request for cjcenizal June 24, 2019 15:46

sebelga added 3 commits June 25, 2019 11:42

Revert "Update generated console autocomplete definitions"

1042ee9

This reverts commit 67ce639.

Remove "xpack." filename prefix

2ead9cb

Update generated console autocomplete definitions

cd68663

sebelga changed the title ~~[Console] Update autocomplete definitions~~ [WIP] Console update autocomplete definitions Jun 25, 2019

sebelga added the WIP Work in progress label Jun 25, 2019

sebelga added 2 commits June 25, 2019 16:42

Add new OSS autocomplete definitions

89c9872

Add new xpack API definitions

8505da2

Add new xpack ML API definition

6b8afe2

Add new xpack ML API payload definition

8d110a1

Update README.md spec to console

afa573e

sebelga requested a review from dimitris-athanasiou June 26, 2019 16:32

sebelga changed the title ~~[WIP] Console update autocomplete definitions~~ Console update autocomplete definitions Jun 26, 2019

cjcenizal self-requested a review June 26, 2019 16:37

alisonelizabeth approved these changes Jun 27, 2019

View reviewed changes

sebelga removed the WIP Work in progress label Jun 27, 2019

cjcenizal reviewed Jul 2, 2019

View reviewed changes

cjcenizal approved these changes Jul 2, 2019

View reviewed changes

dimitris-athanasiou reviewed Jul 2, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into update-console-au…

2151835

…tocomplete-definitions

sebelga merged commit 40089f9 into elastic:master Jul 2, 2019

sebelga deleted the update-console-autocomplete-definitions branch July 2, 2019 16:33

sebelga mentioned this pull request Jul 2, 2019

[7.x] Console update autocomplete definitions (#39508) #40178

Merged

sebelga added a commit to sebelga/kibana that referenced this pull request Jul 2, 2019

Console update autocomplete definitions (elastic#39508)

13960ac

jen-huang pushed a commit that referenced this pull request Jul 2, 2019

Console update autocomplete definitions (#39508) (#40178)

2f63d5f

cjcenizal mentioned this pull request Jul 3, 2019

Autocomplete on aggs in Dev Console is broken in 7.2 #40254

Closed

cjcenizal mentioned this pull request Jul 15, 2019

Dev tools: autocomplete for distance_feature query #41120

Closed

Comments

Conversation

sebelga commented Jun 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 24, 2019

Uh oh!

elasticmachine commented Jun 24, 2019

💔 Build Failed

Uh oh!

cjcenizal commented Jun 24, 2019

Uh oh!

sebelga commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 25, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 26, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 26, 2019

💚 Build Succeeded

Uh oh!

sebelga commented Jun 26, 2019

Uh oh!

elasticmachine commented Jun 26, 2019

💚 Build Succeeded

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

cjcenizal commented Jun 28, 2019

Uh oh!

sebelga commented Jul 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjcenizal commented Jul 1, 2019

Uh oh!

cjcenizal Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dimitris-athanasiou Jul 2, 2019

Choose a reason for hiding this comment

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

dimitris-athanasiou left a comment

Choose a reason for hiding this comment

Uh oh!

sebelga commented Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jul 2, 2019

💔 Build Failed

Uh oh!

sebelga commented Jul 2, 2019

Uh oh!

sebelga commented Jul 2, 2019

Uh oh!

elasticmachine commented Jul 2, 2019

💔 Build Failed

Uh oh!

alisonelizabeth commented Jul 2, 2019

Uh oh!

elasticmachine commented Jul 2, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jul 2, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sebelga commented Jun 24, 2019 •

edited

Loading

sebelga commented Jun 25, 2019 •

edited

Loading

sebelga commented Jul 1, 2019 •

edited

Loading

cjcenizal Jul 2, 2019 •

edited

Loading

sebelga commented Jul 2, 2019 •

edited

Loading