[console] adding generated spec files for xpack endpoints and adjusting code to… by bmcconaghy · Pull Request #19928 · elastic/kibana

bmcconaghy · 2018-06-14T21:55:30Z

… handle the same override logic

xpack spec files are now generated in the same fashion as the OSS spec files with overrides to supply body completions where applicable.

… handle the same override logic

elasticmachine · 2018-06-14T23:12:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-06-15T14:30:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal

I tested about 15% of these endpoints and they seemed to work as expected. I found a couple oddities but I don't think they're related to this PR.

cjcenizal · 2018-06-15T18:09:36Z

x-pack/plugins/console_extensions/spec/overrides/xpack.info.json

+  "_xpack": {
+    "url_params": {
+      "categories": [
+        "build",


Are these supposed to be suggested as values for this param? If so, I don't see them showing up. Let me know if this is a bug and I'll file an issue.

cjcenizal · 2018-06-15T18:10:09Z

x-pack/plugins/console_extensions/spec/overrides/xpack.info.json

+        "license",
+        "features"
+      ],
+      "human": [


Is this supposed to show up as an option?

bmcconaghy · 2018-06-18T13:51:34Z

Good catch @cjcenizal wrong key in override file meant that the override wasn't happening.

elasticmachine · 2018-06-18T15:06:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…ck_console_autocomplete

elasticmachine · 2018-06-18T21:22:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal

Just found a few things which may or may not be of note.

cjcenizal · 2018-06-19T02:19:52Z

x-pack/plugins/console_extensions/spec/overrides/xpack.ml.get_categories.json

@@ -0,0 +1,10 @@
+{
+  "xpack.ml.get_categories": {
+    "data_autocomplete_rules": {


FWIW, I can only get the autocompleter to suggest these for _xpack/ml/anomaly_detectors/{job_id}/results/categories/{category_id}, but not _xpack/ml/anomaly_detectors/{job_id}/results/categories

Good catch, generated file had that path end with a slash, fixed it in overrides.

cjcenizal · 2018-06-19T02:22:14Z

x-pack/plugins/console_extensions/spec/overrides/xpack.ml.get_overall_buckets.json

+{
+  "xpack.ml.get_overall_buckets": {
+    "data_autocomplete_rules": {
+      "allow_no_jobs": [true, false],


This and exclude_interim only populate the field with an empty array, instead of [true, false]. true and false are suggested by the autocompleter if you start typing "t" or "f" however.

Should be fixed now, thanks for catching.

cjcenizal · 2018-06-19T02:25:52Z

x-pack/plugins/console_extensions/spec/overrides/xpack.ml.get_records.json

+{
+  "xpack.ml.get_records": {
+    "data_autocomplete_rules": {
+      "desc": "__flag__",


In the xpack.info endpoint, __flag__ is used within a URL parameter, and autocompleter will suggest true or false as values for the param. In this case, the autocompleter doesn't suggest these values and instead autofills the value as the string "__flag__".

Fixed this here and elsewhere.

cjcenizal · 2018-06-19T02:27:55Z

x-pack/plugins/console_extensions/spec/overrides/xpack.ml.put_datafeed.json

+      "aggregations": {},
+      "chunking_config": {},
+      "frequency": "",
+      "indices": [""],


This array is not pre-populated with an empty string; it's inserted as an empty array.

cjcenizal · 2018-06-19T02:33:24Z

x-pack/plugins/console_extensions/spec/overrides/xpack.rollup.put_job.json

+      "PUT"
+    ],
+    "patterns": [
+      "_xpack/rollup/job/{id}"


Any reason "methods" and "patterns" are defined both here and in the generated file?

bmcconaghy · 2018-06-22T14:38:06Z

@cjcenizal thanks for the thorough testing. I have addressed those things. Would you mind taking a look at this one again?

elasticmachine · 2018-06-22T15:43:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-06-22T16:52:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-06-22T18:54:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…ck_console_autocomplete

elasticmachine · 2018-06-22T20:05:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

jen-huang

Spot tested a handful of endpoints and confirmed that autocomplete kicks in and is correct per spec files.

Code LGTM!

jen-huang · 2018-06-22T20:48:32Z

x-pack/plugins/console_extensions/spec/generated/xpack.rollup.get_jobs.json

+    ],
+    "patterns": [
+      "_xpack/rollup/job/{id}",
+      "_xpack/rollup/job/"


Hitting this endpoint without an id returns an exception, this conflicts with the documentation so is not a console bug, but an Elasticsearch bug (rollup team has been notified and will fix).

…ng code to… (elastic#19928) * adding generated spec files for xpack endpoints and adjusting code to handle the same override logic * accounting for non URL documentation values * fixing issue with incorrect override file * adding support for unknown parameters in path (assuming they are ids) * fixing autocomplete for get_categories ml API * fixing issue with autocomplete for get_overall_buckets * fixing issue with get_overall_buckets autocomplete * fixing get_overall_buckets autocomplete issue for reals * fixing __flag__ in body autocomplete specs * fixing issue with ml put_datafeed autocomplete * removing unnecessary overrides for rollup put_job * fix issue with UrlPatternMatcher * fixing tests * fixing typos * overriding rollup get due to bug in ES specs

…ng code to… (#19928) (#20201) * adding generated spec files for xpack endpoints and adjusting code to handle the same override logic * accounting for non URL documentation values * fixing issue with incorrect override file * adding support for unknown parameters in path (assuming they are ids) * fixing autocomplete for get_categories ml API * fixing issue with autocomplete for get_overall_buckets * fixing issue with get_overall_buckets autocomplete * fixing get_overall_buckets autocomplete issue for reals * fixing __flag__ in body autocomplete specs * fixing issue with ml put_datafeed autocomplete * removing unnecessary overrides for rollup put_job * fix issue with UrlPatternMatcher * fixing tests * fixing typos * overriding rollup get due to bug in ES specs

elasticmachine · 2018-06-25T13:52:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…ng code to… (#19928) * adding generated spec files for xpack endpoints and adjusting code to handle the same override logic * accounting for non URL documentation values * fixing issue with incorrect override file * adding support for unknown parameters in path (assuming they are ids) * fixing autocomplete for get_categories ml API * fixing issue with autocomplete for get_overall_buckets * fixing issue with get_overall_buckets autocomplete * fixing get_overall_buckets autocomplete issue for reals * fixing __flag__ in body autocomplete specs * fixing issue with ml put_datafeed autocomplete * removing unnecessary overrides for rollup put_job * fix issue with UrlPatternMatcher * fixing tests * fixing typos * overriding rollup get due to bug in ES specs

adding generated spec files for xpack endpoints and adjusting code to…

d2a6cd1

… handle the same override logic

bmcconaghy requested review from cjcenizal and jen-huang June 14, 2018 21:55

accounting for non URL documentation values

b35d016

cjcenizal approved these changes Jun 15, 2018

View reviewed changes

fixing issue with incorrect override file

78ddfac

bmcconaghy changed the title ~~adding generated spec files for xpack endpoints and adjusting code to…~~ [console] adding generated spec files for xpack endpoints and adjusting code to… Jun 18, 2018

bmcconaghy added 2 commits June 18, 2018 16:10

adding support for unknown parameters in path (assuming they are ids)

3c97843

Merge branch 'master' of github.com:elastic/kibana into generated_xpa…

a93ceae

…ck_console_autocomplete

cjcenizal reviewed Jun 19, 2018

View reviewed changes

bmcconaghy added 7 commits June 22, 2018 10:19

fixing autocomplete for get_categories ml API

5f810c3

fixing issue with autocomplete for get_overall_buckets

d810891

fixing issue with get_overall_buckets autocomplete

4a6659e

fixing get_overall_buckets autocomplete issue for reals

ea2f26c

fixing __flag__ in body autocomplete specs

fd49973

fixing issue with ml put_datafeed autocomplete

f0547e8

removing unnecessary overrides for rollup put_job

29650ef

fix issue with UrlPatternMatcher

9048ef2

bmcconaghy added 2 commits June 22, 2018 13:02

fixing tests

5f8c58b

fixing typos

59ee158

bmcconaghy added v7.0.0 v6.4.0 labels Jun 22, 2018

Merge branch 'master' of github.com:elastic/kibana into generated_xpa…

0b359a7

…ck_console_autocomplete

jen-huang added the :Management label Jun 22, 2018

jen-huang approved these changes Jun 22, 2018

View reviewed changes

overriding rollup get due to bug in ES specs

4dd019c

bmcconaghy merged commit 39ac92a into elastic:master Jun 25, 2018

bmcconaghy mentioned this pull request Jun 25, 2018

[6.x] [console] adding generated spec files for xpack endpoints and adjusting code to… (#19928) #20201

Merged

bmcconaghy deleted the generated_xpack_console_autocomplete branch June 25, 2018 12:45

This was referenced Aug 17, 2018

[DOCS] Updates links to role management APIs #22150

Merged

[DOCS] Updates links to token APIs #22155

Merged

[DOCS] Updates links to user management APIs #22161

Merged

[DOCS] Updates links to role mapping APIs #22167

Merged

cjcenizal added the Feature:Console Dev Tools Console Feature label May 2, 2019

cjcenizal mentioned this pull request May 2, 2019

Add _xpack endpoint options in the Console UI #17907

Closed

cjcenizal mentioned this pull request Jun 28, 2019

Console update autocomplete definitions #39508

Merged

Conversation

bmcconaghy commented Jun 14, 2018

Uh oh!

elasticmachine commented Jun 14, 2018

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 15, 2018

💚 Build Succeeded

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmcconaghy commented Jun 18, 2018

Uh oh!

elasticmachine commented Jun 18, 2018

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 18, 2018

💔 Build Failed

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmcconaghy commented Jun 22, 2018

Uh oh!

elasticmachine commented Jun 22, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Jun 22, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Jun 22, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Jun 22, 2018

💚 Build Succeeded

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 25, 2018

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments