Skip to content

Allow requestCert option to be set #38920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddself merged 1 commit into from
Jun 13, 2019
Merged

Allow requestCert option to be set #38920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/server/http/ssl_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export const sslSchema = schema.object(
schema.oneOf([schema.literal('TLSv1'), schema.literal('TLSv1.1'), schema.literal('TLSv1.2')]),
{ defaultValue: ['TLSv1.1', 'TLSv1.2'], minSize: 1 }
),
requestCert: schema.maybe(schema.boolean({ defaultValue: false })),
Copy link
Copy Markdown
Contributor

@azasypkin azasypkin Jun 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toddself Hmm, IIRC you either use schema.maybe(schema.boolean()) // requestCert?: boolean or just schema.boolean({ defaultValue: false }) // requestCert: boolean as having default value implies "optionality". Or I'm missing something?

},
{
validate: ssl => {
Expand Down Expand Up @@ -85,6 +86,7 @@ export class SslConfig {
this.keyPassphrase = config.keyPassphrase;
this.cipherSuites = config.cipherSuites;
this.supportedProtocols = config.supportedProtocols;
this.requestCert = config.requestCert;
}

/**
Expand Down