Allow requestCert option to be set#38920
Merged
toddself merged 1 commit intoelastic:masterfrom Jun 13, 2019
Merged
Conversation
This allows you to pass the option in correctly to the constructor
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
💚 Build Succeeded |
toddself
added a commit
to toddself/kibana
that referenced
this pull request
Jun 13, 2019
This allows you to pass the option in correctly to the constructor
toddself
added a commit
that referenced
this pull request
Jun 14, 2019
azasypkin
reviewed
Jun 14, 2019
| schema.oneOf([schema.literal('TLSv1'), schema.literal('TLSv1.1'), schema.literal('TLSv1.2')]), | ||
| { defaultValue: ['TLSv1.1', 'TLSv1.2'], minSize: 1 } | ||
| ), | ||
| requestCert: schema.maybe(schema.boolean({ defaultValue: false })), |
Contributor
There was a problem hiding this comment.
@toddself Hmm, IIRC you either use schema.maybe(schema.boolean()) // requestCert?: boolean or just schema.boolean({ defaultValue: false }) // requestCert: boolean as having default value implies "optionality". Or I'm missing something?
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
new SslConfigto accept therequestCertboolean option to bepassed into the constructor.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
This allows us to require an HTTP server created by Kibana to force a
client to provide a certificate for authorization to the server
instance. This enables PKI-based mutual TLS for client/server
interactions
Creating a configuration as such:
Would require a client to provide the same
certandkey(andcaifit's a self-signed certificate) to the https request in order to the
server to respond:
Without the same certificate, key and ca, the Kibana server will reject
the request as being unauthorized