Skip to content

[SIEM] bug when you delete column on timeline #37946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XavierM merged 1 commit into from
Jun 4, 2019
Merged

[SIEM] bug when you delete column on timeline #37946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/siem/common/graphql/shared/schema.gql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const sharedSchema = gql`
}

type CursorType {
value: String!
value: String
tiebreaker: String
}

Expand Down
7 changes: 6 additions & 1 deletion x-pack/plugins/siem/public/components/timeline/body/column_headers/actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ export const CloseButton = pure<{
aria-label={i18n.REMOVE_COLUMN}
data-test-subj="remove-column"
iconType="cross"
onClick={() => onColumnRemoved(columnId)}
onClick={(event: React.MouseEvent<HTMLButtonElement>) => {
// To avoid a re-sorting when you delete a column
event.preventDefault();
event.stopPropagation();
onColumnRemoved(columnId);
}}
/>
</WrappedCloseButton>
));
Expand Down
6 changes: 1 addition & 5 deletions x-pack/plugins/siem/public/graphql/introspection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2955,11 +2955,7 @@
"name": "value",
"description": "",
"args": [],
"type": {
"kind": "NON_NULL",
"name": null,
"ofType": { "kind": "SCALAR", "name": "String", "ofType": null }
},
"type": { "kind": "SCALAR", "name": "String", "ofType": null },
"isDeprecated": false,
"deprecationReason": null
},
Expand Down
38 changes: 19 additions & 19 deletions x-pack/plugins/siem/public/graphql/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export interface OsEcsFields {
}

export interface CursorType {
value: string;
value?: string | null;

tiebreaker?: string | null;
}
Expand Down Expand Up @@ -2181,7 +2181,7 @@ export namespace GetAuthenticationsQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -2195,7 +2195,7 @@ export namespace GetAuthenticationsQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -2323,7 +2323,7 @@ export namespace GetDomainsQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -2337,7 +2337,7 @@ export namespace GetDomainsQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -2386,7 +2386,7 @@ export namespace GetEventsQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;

tiebreaker?: string | null;
};
Expand Down Expand Up @@ -2634,7 +2634,7 @@ export namespace GetHostsTableQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -2648,7 +2648,7 @@ export namespace GetHostsTableQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -3090,7 +3090,7 @@ export namespace GetNetworkDnsQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -3104,7 +3104,7 @@ export namespace GetNetworkDnsQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -3219,7 +3219,7 @@ export namespace GetNetworkTopNFlowQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -3233,7 +3233,7 @@ export namespace GetNetworkTopNFlowQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -3609,7 +3609,7 @@ export namespace GetTimelineQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;

tiebreaker?: string | null;
};
Expand Down Expand Up @@ -4838,7 +4838,7 @@ export namespace GetTlsQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -4852,7 +4852,7 @@ export namespace GetTlsQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -4936,7 +4936,7 @@ export namespace GetUncommonProcessesQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -4950,7 +4950,7 @@ export namespace GetUncommonProcessesQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down Expand Up @@ -5021,7 +5021,7 @@ export namespace GetUsersQuery {
export type Cursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};

export type PageInfo = {
Expand All @@ -5035,7 +5035,7 @@ export namespace GetUsersQuery {
export type EndCursor = {
__typename?: 'CursorType';

value: string;
value?: string | null;
};
}

Expand Down
14 changes: 7 additions & 7 deletions x-pack/plugins/siem/server/graphql/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ export interface OsEcsFields {
}

export interface CursorType {
value: string;
value?: string | null;

tiebreaker?: string | null;
}
Expand Down Expand Up @@ -3342,16 +3342,16 @@ export namespace OsEcsFieldsResolvers {

export namespace CursorTypeResolvers {
export interface Resolvers<Context = SiemContext, TypeParent = CursorType> {
value?: ValueResolver<string, TypeParent, Context>;
value?: ValueResolver<string | null, TypeParent, Context>;

tiebreaker?: TiebreakerResolver<string | null, TypeParent, Context>;
}

export type ValueResolver<R = string, Parent = CursorType, Context = SiemContext> = Resolver<
R,
Parent,
Context
>;
export type ValueResolver<
R = string | null,
Parent = CursorType,
Context = SiemContext
> = Resolver<R, Parent, Context>;
export type TiebreakerResolver<
R = string | null,
Parent = CursorType,
Expand Down