[SIEM] bug when you delete column on timeline#37946
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/secops |
Contributor
💚 Build Succeeded |
angorayc
approved these changes
Jun 4, 2019
Contributor
angorayc
left a comment
There was a problem hiding this comment.
@XavierM, thank you for fixing this! Checked out the code and no issue found. For me I think it is fine to leave it like this without picking another sorting field, but would be helpful to me if there is a prompt to remind me before deleting the sorting field.
tsg
approved these changes
Jun 4, 2019
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jun 4, 2019
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jun 4, 2019
XavierM
added a commit
that referenced
this pull request
Jun 4, 2019
XavierM
added a commit
that referenced
this pull request
Jun 4, 2019
jgowdyelastic
pushed a commit
that referenced
this pull request
Jun 4, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user deletes a column on the timeline, this column became the sorting columns. This should not happen.
And this bug also brought up that it is possible for a user to sort column where all the value are null. and that's ok if user wants to do that. So we changed the type in
graphqlto allow it.We might also want to think about this situation. If the column that we are going to delete is the sorting column/field in the timeline, do we want to pick a new sorting column/field in the timeline for less confusion? any thought? By the way, I do not mind to add it in this PR but just want to make sure that we are all on the same page.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately