Skip to content

[SIEM] bug when you delete column on timeline#37946

Merged
XavierM merged 1 commit into
elastic:masterfrom
XavierM:bug-delete-columns
Jun 4, 2019
Merged

[SIEM] bug when you delete column on timeline#37946
XavierM merged 1 commit into
elastic:masterfrom
XavierM:bug-delete-columns

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Jun 4, 2019

Summary

When a user deletes a column on the timeline, this column became the sorting columns. This should not happen.

And this bug also brought up that it is possible for a user to sort column where all the value are null. and that's ok if user wants to do that. So we changed the type in graphql to allow it.

We might also want to think about this situation. If the column that we are going to delete is the sorting column/field in the timeline, do we want to pick a new sorting column/field in the timeline for less confusion? any thought? By the way, I do not mind to add it in this PR but just want to make sure that we are all on the same page.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM XavierM added loe:small Small Level of Effort Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.2.0 labels Jun 4, 2019
@XavierM XavierM self-assigned this Jun 4, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/secops

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierM, thank you for fixing this! Checked out the code and no issue found. For me I think it is fine to leave it like this without picking another sorting field, but would be helpful to me if there is a prompt to remind me before deleting the sorting field.

@XavierM XavierM merged commit 5ac71cf into elastic:master Jun 4, 2019
XavierM added a commit to XavierM/kibana that referenced this pull request Jun 4, 2019
XavierM added a commit to XavierM/kibana that referenced this pull request Jun 4, 2019
XavierM added a commit that referenced this pull request Jun 4, 2019
XavierM added a commit that referenced this pull request Jun 4, 2019
jgowdyelastic pushed a commit that referenced this pull request Jun 4, 2019
@XavierM XavierM deleted the bug-delete-columns branch June 4, 2020 16:23
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants