Skip to content

[Tagcloud] Allow to send showLabel parameter with false value #36563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2019
Merged

[Tagcloud] Allow to send showLabel parameter with false value #36563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d9d6ab
Allow to send showLabel parameter with false value
maryia-lapata May 15, 2019
30f1c48
Merge branch 'master' into 36526
maryia-lapata May 20, 2019
b6fc918
Merge branch 'master' into 36526
maryia-lapata May 23, 2019
f3e5447
Add unit test
maryia-lapata May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...acy/ui/public/visualize/loader/pipeline_helpers/__snapshots__/build_pipeline.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@ describe('visualize loader pipeline helpers: build pipeline', () => {
const actual = buildPipelineVisFunction.tagcloud({ params }, schemas);
expect(actual).toMatchSnapshot();
});

it('with boolean param showLabel', () => {
const schemas = { metric: [{ accessor: 0 }] };
const params = { showLabel: false };
const actual = buildPipelineVisFunction.tagcloud({ params }, schemas);
expect(actual).toMatchSnapshot();
});

});

describe('handles region_map function', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export const buildPipelineVisFunction: BuildPipelineVisFunction = {
if (maxFontSize) {
expr += `maxFontSize=${maxFontSize} `;
}
if (showLabel) {
if (showLabel !== undefined) {
expr += `showLabel=${showLabel} `;
}

Expand Down