[Tagcloud] Allow to send showLabel parameter with false value #36563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-lapata
added
Feature:Tagcloud
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
|
@lukeelmers This is the PR we talked about offline. Do you think we should still merge this before rewriting the conversion function into a more permanent state? |
Contributor
|
i think we def should, the new conversion function my take a while |
Member
|
@timroes Yep I think we should still merge. Cleaning this up will involve a bit more effort as we also need to shift to building the AST directly, so in the interest of time we might just want to merge this now. Also I would consider adding a quick snapshot test for this use case — that will help us avoid regressions when doing the cleanup |
Contributor
Author
|
@lukeelmers I added a small unit test. Could you please review this PR? |
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
May 23, 2019
Member
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this 🙏
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
May 24, 2019
…c#36563) * Allow to send showLabel parameter with false value * Add unit test
maryia-lapata
added a commit
that referenced
this pull request
May 24, 2019
#37054) * Allow to send showLabel parameter with false value * Add unit test
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Jul 5, 2019
…c#36563) * Allow to send showLabel parameter with false value * Add unit test
timroes
pushed a commit
that referenced
this pull request
Jul 5, 2019
#40437) * Allow to send showLabel parameter with false value * Add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #36526
Related to #33773
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately