[Logstash] [Stack Monitoring] Add new metric to check for pipelines missing a pipeline.id field#34435
Closed
justinkambic wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
Contributor
Author
|
Closed in favor of #34487. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #24279.
As noted in the issue referenced above, older versions of Logstash (pre-6.4.0) will not display in Monitoring's Overview page unless a newer version of LS is also running. The reason this happens is also explained in comments on that issue.
The goal here is to add a second metric that will detect monitoring documents from older Logstash instances. Essentially, if there are any instances without a
pipeline.idfield, we would treat that as a case where we should ignore the special logic that runs to hide LS until the monitoring index has accrued a sufficient amount of data.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers