Skip to content

[Logstash] [Stack Monitoring] Add new metric to check for pipelines missing a pipeline.id field#34435

Closed
justinkambic wants to merge 1 commit intoelastic:masterfrom
justinkambic:logstash_monitoring-display-older-version-pipelines
Closed

[Logstash] [Stack Monitoring] Add new metric to check for pipelines missing a pipeline.id field#34435
justinkambic wants to merge 1 commit intoelastic:masterfrom
justinkambic:logstash_monitoring-display-older-version-pipelines

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

Summary

Resolves #24279.

As noted in the issue referenced above, older versions of Logstash (pre-6.4.0) will not display in Monitoring's Overview page unless a newer version of LS is also running. The reason this happens is also explained in comments on that issue.

The goal here is to add a second metric that will detect monitoring documents from older Logstash instances. Essentially, if there are any instances without a pipeline.id field, we would treat that as a case where we should ignore the special logic that runs to hide LS until the monitoring index has accrued a sufficient amount of data.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience WIP Work in progress Team:Logstash v7.2.0 v6.7.2 labels Apr 3, 2019
@justinkambic justinkambic self-assigned this Apr 3, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@justinkambic
Copy link
Copy Markdown
Contributor Author

Closed in favor of #34487.

@justinkambic justinkambic deleted the logstash_monitoring-display-older-version-pipelines branch April 3, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Team:Logstash v6.7.2 v7.2.0 WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants