Skip to content

[5.6] Bump node to 6.17.0 #32201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2019
Merged

[5.6] Bump node to 6.17.0 #32201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a393f3
Bump node to 6.17.0
jbudz Feb 28, 2019
96ef552
Resolve intermittent premature connection closed (#19808)
tylersmalley Jun 11, 2018
54e35ec
6
jbudz Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.16.0
6.17.0
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@
"xmlbuilder": "9.0.4"
},
"engines": {
"node": "6.16.0",
"node": "6.17.0",
"npm": "3.10.10"
}
}
11 changes: 9 additions & 2 deletions src/server/http/setup_connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,15 @@ export default function (kbnServer, server, config) {

// not using https? well that's easy!
if (!useSsl) {
server.connection(connectionOptions);
const connection = server.connection(connectionOptions);

// revert to previous 2m keepalive timeout in Node < 6
connection.listener.keepAliveTimeout = 120e3;

return;
}

server.connection({
const connection = server.connection({
...connectionOptions,
tls: true,
listener: httpolyglot.createServer({
Expand All @@ -54,6 +58,9 @@ export default function (kbnServer, server, config) {
})
});

// revert to previous 2m keepalive timeout in Node < 6
connection.listener.keepAliveTimeout = 120e3;

server.ext('onRequest', function (req, reply) {
// A request sent through a HapiJS .inject() doesn't have a socket associated with the request
// which causes a failure.
Expand Down