Skip to content

[5.6] Bump node to 6.17.0 #32201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2019
Merged

[5.6] Bump node to 6.17.0 #32201

merged 3 commits into from
Mar 8, 2019

Conversation

@jbudz
Copy link
Member

@jbudz jbudz commented Feb 28, 2019 •
edited
Loading

@jbudz jbudz added review Team:Operations Kibana-Operations Team v5.6.16 labels Feb 28, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 28, 2019

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 28, 2019

💚 Build Succeeded

@jbudz
Copy link
Member Author

jbudz commented Feb 28, 2019

This is a sneaky update.

kibana/src/core/server/http/http_tools.ts

Line 85 in 4aa2a4c

server.listener.keepAliveTimeout = 120e3;
needs to be backported

tylersmalley and others added 2 commits March 6, 2019 12:29
@tylersmalley @jbudz
Resolve intermittent premature connection closed (elastic#19808)
96ef552 
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior.

Signed-off-by: Tyler Smalley <[email protected]>
@jbudz
6
54e35ec
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2019

💚 Build Succeeded

mistic
mistic approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz jbudz merged commit e4c8b3e into elastic:5.6 Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

Assignees

No one assigned

Labels

review Team:Operations Kibana-Operations Team v5.6.16

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbudz @elasticmachine @mistic @tylersmalley