Skip to content
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d209cc3
moved vis table to use EUI
Feb 10, 2019
3087cef
Create base class for table list view
Feb 12, 2019
ef54f07
use EuiInMemoryTable
Feb 12, 2019
c219de5
update tests
Feb 12, 2019
7ddc564
Merge branch 'master' into visualization-list-eui
Feb 12, 2019
2d160f7
added missing scss file
Feb 12, 2019
bcaa51a
newline scss file
Feb 12, 2019
d67f876
remove custom css + deleting text
Feb 12, 2019
6a61239
Merge branch 'master' into visualization-list-eui
Feb 12, 2019
3697864
fixing functional tests
Feb 13, 2019
48ca6bb
updating dashboard tests
Feb 13, 2019
419e35e
added tests for visualize app
Feb 14, 2019
04f4c98
Merge branch 'master' into visualization-list-eui
Feb 14, 2019
44df687
Merge branch 'master' into visualization-list-eui
Feb 17, 2019
f0ab396
actions column width, flask icon and test fix
Feb 17, 2019
4a33ac6
clean all visualizations before testing list
Feb 17, 2019
75865f5
removed unused string translations
Feb 17, 2019
7676dd6
update snapshots
Feb 17, 2019
5c125fb
remove after
Feb 17, 2019
d136672
code review updates + snapshots
Feb 18, 2019
1640cb5
Merge branch 'master' into visualization-list-eui
Feb 18, 2019
e290cc8
removed unnecessary exists in dashboards page
Feb 18, 2019
00f4abc
code review fixes
Feb 18, 2019
e206e6f
update snapshots
Feb 18, 2019
e581f82
Merge branch 'master' into visualization-list-eui
Feb 18, 2019
ae3f4bb
improve tests
Feb 18, 2019
4497ed7
merge master
Feb 20, 2019
a514736
improve experimental badge
Feb 20, 2019
a52fc12
scss vars
Feb 20, 2019
cde4fa5
Merge branch 'master' into visualization-list-eui
Feb 21, 2019
227413f
Fixing bugs from #31599
Feb 21, 2019
50b8935
revert test change
Feb 21, 2019
e6e4029
Merge branch 'master' into visualization-list-eui
Feb 21, 2019
a91e54b
missing # on URLs
Feb 21, 2019
39ab264
fixed test
Feb 21, 2019
894d3f6
Merge branch 'master' into visualization-list-eui
Feb 25, 2019
800b357
code review
Feb 25, 2019
5c72c38
restore dashboard edit button behavior
Feb 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/legacy/core_plugins/kibana/public/dashboard/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,12 @@ uiRoutes
$scope.find = (search) => {
return services.dashboards.find(search, $scope.listingLimit);
};
$scope.edit = ({ id }) => {
$scope.editItem = ({ id }) => {
kbnUrl.redirect(createDashboardEditUrl(id));
};
$scope.getEditUrl = ({ id }) => {
return createDashboardEditUrl(id);
};
$scope.delete = (ids) => {
return services.dashboards.delete(ids);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ class DashboardListingUi extends React.Component {
sortable: true,
render: (field, record) => (
<EuiLink
onClick={() => this.props.editItem(record)}
href={this.props.getEditUrl(record)}
data-test-subj={`dashboardListingTitleLink-${record.title.split(' ').join('-')}`}
>
{field}
Expand All @@ -185,6 +185,7 @@ DashboardListingUi.propTypes = {
findItems: PropTypes.func.isRequired,
deleteItems: PropTypes.func.isRequired,
editItem: PropTypes.func.isRequired,
getEditUrl: PropTypes.func.isRequired,
listingLimit: PropTypes.number.isRequired,
hideWriteControls: PropTypes.bool.isRequired,
initialFilter: PropTypes.string,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<dashboard-listing
create-item="create"
edit-item="edit"
get-edit-url="getEditUrl"
edit-item="editItem"
find-items="find"
delete-items="delete"
listing-limit="listingLimit"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ class TableListViewUi extends React.Component {
showLimitError: false,
filter: this.props.initialFilter,
selectedIds: [],
sortField: 'title',
sortDirection: 'asc',
sortField: '',
sortDirection: '',
page: 0,
perPage: 20,
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
find-items="listingController.fetchItems"
delete-items="listingController.deleteSelectedItems"
create-item="listingController.createNewVis"
edit-item="listingController.edit"
get-edit-url="listingController.getEditUrl"
edit-item="listingController.editItem"
></visualize-listing-table>

<new-vis-modal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@ export function VisualizeListingController($injector, createNewVis) {
this.showNewVisModal = true;
};

this.edit = ({ id }) => {
kbnUrl.change(createVisualizeEditUrl(id));
this.editItem = ({ id }) => {
kbnUrl.redirect(createVisualizeEditUrl(id));
};

this.getEditUrl = ({ id }) => {
return createVisualizeEditUrl(id);
};

this.closeNewVisModal = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class VisualizeListingTableUi extends Component {
sortable: true,
render: (field, record) => (
<EuiLink
onClick={() => this.props.editItem(record)}
href={this.props.getEditUrl(record)}
data-test-subj={`visListingTitleLink-${record.title.split(' ').join('-')}`}
>
{field}
Expand Down Expand Up @@ -219,6 +219,7 @@ VisualizeListingTableUi.propTypes = {
deleteItems: PropTypes.func.isRequired,
findItems: PropTypes.func.isRequired,
createItem: PropTypes.func.isRequired,
getEditUrl: PropTypes.func.isRequired,
editItem: PropTypes.func.isRequired,
};

Expand Down