Visualization list eui #31686
Merged
Visualization list eui #31686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 10, 2019 18:03
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
timroes
suggested changes
Feb 21, 2019
src/legacy/core_plugins/kibana/public/table_list_view/table_list_view.js
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
timroes
reviewed
Feb 21, 2019
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
timroes
approved these changes
Feb 25, 2019
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Tested on Chrome Linux, looks good to me. Code LGTM
Contributor
💚 Build Succeeded |
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Feb 25, 2019
* Fixing bugs from elastic#31599 * Make listing item links instead of buttons * restore dashboard edit button behavior
lizozom
added a commit
that referenced
this pull request
Feb 26, 2019
Contributor
|
Pinging @elastic/eui-design (EUI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Issues with new Listing component #31599