Skip to content

[DOCS] Removes X-Pack settings section#30554

Merged
lcawl merged 2 commits intoelastic:masterfrom
lcawl:xpack-settings
Feb 11, 2019
Merged

[DOCS] Removes X-Pack settings section#30554
lcawl merged 2 commits intoelastic:masterfrom
lcawl:xpack-settings

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 8, 2019

Summary

This PR removes the "X-Pack Settings" section from the Kibana User Guide. Instead, those pages are moved under Set up Kibana > Configuring Kibana.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

[skip ci]

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@lcawl
Copy link
Contributor Author

lcawl commented Feb 8, 2019

Something to consider is whether you prefer that pages that just contain one or two settings (like the "Development tools settings" and "Graph settings", and "Machine learning settings" for example) be integrated into the main "Configuring Kibana" page instead (as was done for the rollup and license management settings).

In my opinion it's a good idea to leave them as-is so they can be linking to separately, but I'm open to other ideas.

Copy link
Contributor

@schersh schersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally, LGTM.

@schersh
Copy link
Contributor

schersh commented Feb 11, 2019

Something to consider is whether you prefer that pages that just contain one or two settings (like the "Development tools settings" and "Graph settings", and "Machine learning settings" for example) be integrated into the main "Configuring Kibana" page instead (as was done for the rollup and license management settings).

In my opinion it's a good idea to leave them as-is so they can be linking to separately, but I'm open to other ideas.

I would agree that it's helpful to have those settings as separate pages. The main Configuring Kibana page might be helped by subsections or some kind of linked TOC? There's a lot of info there.

@lcawl lcawl merged commit f05f0e1 into elastic:master Feb 11, 2019
@lcawl lcawl deleted the xpack-settings branch February 11, 2019 16:17
lcawl added a commit to lcawl/kibana that referenced this pull request Feb 11, 2019
lcawl added a commit to lcawl/kibana that referenced this pull request Feb 11, 2019
graphaelli pushed a commit to graphaelli/kibana that referenced this pull request Mar 5, 2019
bmorelli25 pushed a commit to graphaelli/kibana that referenced this pull request Mar 12, 2019
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 15, 2019
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 15, 2019
bmorelli25 added a commit that referenced this pull request Mar 15, 2019
* fix spelling

# Conflicts:
#	docs/settings/apm-settings.asciidoc

* docs: add sentence on where to change apm settings (#27069)

* [DOCS] Removes X-Pack settings section (#30554)

Just the apm settings changes

* Updates * characters to an escaped * (#22269)

GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.

# Conflicts:
#	docs/settings/apm-settings.asciidoc

* fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants