[APM] Docs: Add sentence on where to change APM settings#27069
Merged
bmorelli25 merged 1 commit intoelastic:masterfrom Dec 18, 2018
Merged
[APM] Docs: Add sentence on where to change APM settings#27069bmorelli25 merged 1 commit intoelastic:masterfrom
bmorelli25 merged 1 commit intoelastic:masterfrom
Conversation
bmorelli25
added
Team:Docs
Team:APM - DEPRECATED
Contributor
|
Pinging @elastic/apm-ui |
Contributor
💔 Build Failed |
Member
Author
|
@sqren - is it OK to merge even thought the build failed? |
Member
|
Generally no. Normally I would just re-run the build (you do that by comment "retest") but in this case it doesn't seem like a random failure. Rather it's due to invalid formatting in canvas: This might already be fixed, so try pulling in master. |
Member
|
It was fixed here: #26985. |
Member
Author
|
Hmmm... |
Member
|
🤞 |
bmorelli25
force-pushed
the
update-apm-settings
branch
from
154d38a to
bacb922
Compare
ogupte
approved these changes
Dec 13, 2018
Contributor
💔 Build Failed |
Member
|
retest |
Member
|
The latest failure looks to be intermittent. Let's try again. Third time's a charm... |
Member
|
@bmorelli25 I'm seeing the same error as you are. Seems to be a Kibana-wide issue right now - nothing we can do atm. |
Contributor
💔 Build Failed |
Member
Author
|
Makes sense - thanks for your help with this @sqren! |
Member
Author
|
retest |
Contributor
💔 Build Failed |
bmorelli25
force-pushed
the
update-apm-settings
branch
from
bacb922 to
3155f63
Compare
Contributor
💔 Build Failed |
bmorelli25
force-pushed
the
update-apm-settings
branch
from
3155f63 to
b6d4cac
Compare
Member
Author
|
retest |
Contributor
💚 Build Succeeded |
Member
|
I'll be damned. A Christmas miracle 🥳🤶🎁 |
Member
Author
|
YES!!!!! 🥇🕺 |
graphaelli
pushed a commit
to graphaelli/kibana
that referenced
this pull request
Mar 5, 2019
bmorelli25
added a commit
to graphaelli/kibana
that referenced
this pull request
Mar 12, 2019
bmorelli25
added a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 15, 2019
bmorelli25
added a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 15, 2019
This was referenced Mar 15, 2019
bmorelli25
added a commit
that referenced
this pull request
Mar 15, 2019
* fix spelling # Conflicts: # docs/settings/apm-settings.asciidoc * docs: add sentence on where to change apm settings (#27069) * [DOCS] Removes X-Pack settings section (#30554) Just the apm settings changes * Updates * characters to an escaped * (#22269) GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine. # Conflicts: # docs/settings/apm-settings.asciidoc * fix conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a sentence on where to change APM settings, per #24204