[es] scripts.inline -> scripts.source #30457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/kibana-operations |
Contributor
💚 Build Succeeded |
peteharverson
approved these changes
Feb 8, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Change to ML watch.js file LGTM
Member
Author
|
+@elastic/es-ui, any concerns? |
Contributor
|
LGTM @jbudz |
Contributor
💚 Build Succeeded |
jbudz
added a commit
that referenced
this pull request
Feb 25, 2019
jbudz
added a commit
that referenced
this pull request
Feb 25, 2019
Contributor
|
@jbudz @mistic @peteharverson guys, why this PR wasn't backported to 6.7? For 6.7. we also have this deprecation message
|
Contributor
|
@jbudz would you mind backporting this to 6.7 as well? |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Mar 7, 2019
jbudz
added a commit
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"inline" is deprecated with "source".
elastic/elasticsearch#25127
Closes #19931