Skip to content

Remove warnings about last minor from Upgrade Assistant #29467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshdover merged 1 commit into from
Jan 29, 2019
Merged

Remove warnings about last minor from Upgrade Assistant #29467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions x-pack/plugins/upgrade_assistant/public/components/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { injectI18n } from '@kbn/i18n/react';
import chrome from 'ui/chrome';

import { UpgradeAssistantStatus } from '../../server/lib/es_migration_apis';
import { LatestMinorBanner } from './latest_minor_banner';
import { CheckupTab } from './tabs/checkup';
import { OverviewTab } from './tabs/overview';
import { LoadingState, UpgradeAssistantTabProps } from './types';
Expand Down Expand Up @@ -88,8 +87,6 @@ export class UpgradeAssistantTabsUI extends React.Component<
loadingState,
refreshCheckupData: this.loadData,
setSelectedTabIndex: this.setSelectedTabIndex,
// Remove this in last minor of the current major (eg. 6.7)
alertBanner: <LatestMinorBanner />,
};

return [
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/upgrade_assistant/public/components/tabs/overview/steps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { DeprecationLoggingToggle } from './deprecation_logging_toggle';

// Leaving these here even if unused so they are picked up for i18n static analysis
// Keep this until last minor release (when next major is also released).
// @ts-ignore
const WAIT_FOR_RELEASE_STEP = {
title: i18n.translate('xpack.upgradeAssistant.overviewTab.steps.waitForReleaseStep.stepTitle', {
defaultMessage: 'Wait for the Elasticsearch {nextEsVersion} release',
Expand Down Expand Up @@ -266,7 +267,7 @@ export const StepsUI: StatelessComponent<
},

// Swap in START_UPGRADE_STEP on the last minor release.
WAIT_FOR_RELEASE_STEP,
START_UPGRADE_STEP,
]}
/>
);
Expand Down