[CCR] Tell user when multiple auto-follow patterns try to replicate the same data#27783
Merged
sebelga merged 5 commits intoelastic:masterfrom Dec 28, 2018
Conversation
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/es-ui |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
@jen-huang I added the UI to fix the bug so you can test the complete flow. cheers! |
Contributor
💔 Build Failed |
…attern-when-multiple-auto-follow-patterns-try-to-replicate-the-same-data
Contributor
💚 Build Succeeded |
jen-huang
approved these changes
Dec 28, 2018
Contributor
jen-huang
left a comment
There was a problem hiding this comment.
Very nice, tested locally and code LGTM!
A timestamp field was added in ES for 6.7: elastic/elasticsearch#36947
We should conditionally show this information if it exists - but that can be done in a follow up PR since it's not needed for 6.6!
Contributor
Author
|
Great thanks for the update on ES |
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Dec 28, 2018
…he same data (elastic#27783) * Fix small tipo * [CCR] Add API to fetch ccr stats * Add deserialization for recentAutoFollowErrors & autoFollowedClusters * Add UI to display recent auto-follow pattern errors
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Dec 28, 2018
…he same data (elastic#27783) * Fix small tipo * [CCR] Add API to fetch ccr stats * Add deserialization for recentAutoFollowErrors & autoFollowedClusters * Add UI to display recent auto-follow pattern errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix a bug where the UI silently fail when 2 auto-follow patterns try to replicate the same index on the leader (see issue #27428) we need to fetch the CCR stats and display the possible errors for an auto-follow pattern.
This PR add 3 API endpoints for the stats
GET /cross_cluster_replication/stats(all the stats coming from ES)GET /cross_cluster_replication/stats/auto-follow(only the auto-follow pattern stats)Test
In order to reproduce the error:
kiba*andkibana*Fixes #27428