[CCR] Added auto_follow_exception.timestamp field to auto follow stats#36947
Merged
martijnvg merged 3 commits intoelastic:masterfrom Dec 24, 2018
Merged
Conversation
…ats. Currently auto follow stats users are unable to see whether an auto follow error was recent or old. The new timestamp field will help user distinguish between old and new errors.
martijnvg
added
>enhancement
v7.0.0
:Distributed/CCR
Collaborator
|
Pinging @elastic/es-distributed |
martijnvg
changed the title
auto_follow_exception.timestamp field to auto follow stats
jasontedor
requested changes
Dec 21, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
We want a real clock instead of the relative clock, so that the timestamps are meaningful.
| } | ||
|
|
||
| synchronized void updateStats(List<AutoFollowResult> results) { | ||
| long newStatsReceivedTimeStamp = relativeMillisTimeProvider.getAsLong(); |
Member
There was a problem hiding this comment.
We want the absolute time provider here!
Member
Author
There was a problem hiding this comment.
whoops, you're absolutely right. I guess I made it this change too quickly...
Member
Author
|
@jasontedor I've addressed the sloppiness in this PR. |
martijnvg
added a commit
that referenced
this pull request
Dec 24, 2018
#36947) Currently auto follow stats users are unable to see whether an auto follow error was recent or old. The new timestamp field will help user distinguish between old and new errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently auto follow stats users are unable to see whether an auto follow
error was recent or old. The new timestamp field will help user distinguish
between old and new errors.