[9.4] [ES|QL] Handles dom exceptions (#270603)#271169
Merged
Merged
Conversation
## Summary This is a regression caused by elastic#242346. It changed the error: from the original throwError(() => new AbortError()) to throwError(() => new AbortError((e.target as AbortSignal)?.reason)), intending to preserve the abort reason in the error. The editor though was not handling this kind of errors correctly causing the following bug: - I am in Lens ES|QL - I cancel the query - I see an error at the footer of my editor - I click the error - 💥 This PR handles this kind of errors gracefully <img width="722" height="493" alt="image" src="https://github.com/user-attachments/assets/374eadfd-93e0-47d8-8e2f-a2e2c1e3caaf" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 55690be) # Conflicts: # src/platform/packages/private/kbn-esql-editor/src/helpers.ts
1 task
kibanamachine
requested review from
sddonne
and removed request for
kibanamachine
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation