[ES|QL] Handles dom exceptions#270603
Merged
Merged
Conversation
stratoula
added
release_note:fix
v9.5.0
v9.4.2
backport:version
|
Pinging @elastic/kibana-esql (Team:ESQL) |
sddonne
approved these changes
May 22, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History |
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/26293283483 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jcger
pushed a commit
that referenced
this pull request
May 26, 2026
## Summary This is a regression caused by #242346. It changed the error: from the original throwError(() => new AbortError()) to throwError(() => new AbortError((e.target as AbortSignal)?.reason)), intending to preserve the abort reason in the error. The editor though was not handling this kind of errors correctly causing the following bug: - I am in Lens ES|QL - I cancel the query - I see an error at the footer of my editor - I click the error - 💥 This PR handles this kind of errors gracefully <img width="722" height="493" alt="image" src="https://github.com/user-attachments/assets/374eadfd-93e0-47d8-8e2f-a2e2c1e3caaf" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
stratoula
added a commit
that referenced
this pull request
May 26, 2026
# Backport This will backport the following commits from `main` to `9.4`: - [[ES|QL] Handles dom exceptions (#270603)](#270603) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratou","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2026-05-22T14:21:08Z","message":"[ES|QL] Handles dom exceptions (#270603)\n\n## Summary\n\nThis is a regression caused by\nhttps://github.com//pull/242346. It changed the error:\nfrom the original throwError(() => new AbortError()) to throwError(() =>\nnew AbortError((e.target as AbortSignal)?.reason)), intending to\npreserve the abort reason in the error.\n\nThe editor though was not handling this kind of errors correctly causing\nthe following bug:\n\n- I am in Lens ES|QL\n- I cancel the query\n- I see an error at the footer of my editor\n- I click the error\n- 💥 \n\nThis PR handles this kind of errors gracefully\n\n<img width=\"722\" height=\"493\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/374eadfd-93e0-47d8-8e2f-a2e2c1e3caaf\"\n/>\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"55690be1086a3f9316b0a0c150b41eca7de1af6e","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.5.0","v9.4.2"],"title":"[ES|QL] Handles dom exceptions","number":270603,"url":"https://github.com/elastic/kibana/pull/270603","mergeCommit":{"message":"[ES|QL] Handles dom exceptions (#270603)\n\n## Summary\n\nThis is a regression caused by\nhttps://github.com//pull/242346. It changed the error:\nfrom the original throwError(() => new AbortError()) to throwError(() =>\nnew AbortError((e.target as AbortSignal)?.reason)), intending to\npreserve the abort reason in the error.\n\nThe editor though was not handling this kind of errors correctly causing\nthe following bug:\n\n- I am in Lens ES|QL\n- I cancel the query\n- I see an error at the footer of my editor\n- I click the error\n- 💥 \n\nThis PR handles this kind of errors gracefully\n\n<img width=\"722\" height=\"493\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/374eadfd-93e0-47d8-8e2f-a2e2c1e3caaf\"\n/>\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"55690be1086a3f9316b0a0c150b41eca7de1af6e"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/270603","number":270603,"mergeCommit":{"message":"[ES|QL] Handles dom exceptions (#270603)\n\n## Summary\n\nThis is a regression caused by\nhttps://github.com//pull/242346. It changed the error:\nfrom the original throwError(() => new AbortError()) to throwError(() =>\nnew AbortError((e.target as AbortSignal)?.reason)), intending to\npreserve the abort reason in the error.\n\nThe editor though was not handling this kind of errors correctly causing\nthe following bug:\n\n- I am in Lens ES|QL\n- I cancel the query\n- I see an error at the footer of my editor\n- I click the error\n- 💥 \n\nThis PR handles this kind of errors gracefully\n\n<img width=\"722\" height=\"493\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/374eadfd-93e0-47d8-8e2f-a2e2c1e3caaf\"\n/>\n\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"55690be1086a3f9316b0a0c150b41eca7de1af6e"}},{"branch":"9.4","label":"v9.4.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a regression caused by #242346. It changed the error: from the original throwError(() => new AbortError()) to throwError(() => new AbortError((e.target as AbortSignal)?.reason)), intending to preserve the abort reason in the error.
The editor though was not handling this kind of errors correctly causing the following bug:
This PR handles this kind of errors gracefully
Checklist