[Canvas][i18n] Apply i18n to public/lib#27084
Closed
clintandrewhall wants to merge 0 commit intoelastic:masterfrom
Closed
[Canvas][i18n] Apply i18n to public/lib#27084clintandrewhall wants to merge 0 commit intoelastic:masterfrom
clintandrewhall wants to merge 0 commit intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
3 tasks
Contributor
💔 Build Failed |
clintandrewhall
force-pushed
the
master
branch
from
9792dcd to
93e3a4c
Compare
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a preview of an approach I want to take with i18n in Canvas. @spalger is helping me with some Typescript issues, but I wanted the approach in front of people for a quick sanity check: is this how we can handle i18n in our files, and, if not, how can this be improved?
This change incorporates and supersedes #23752