Feature/translate canvas public lib#23752
Closed
Nox911 wants to merge 23 commits intoelastic:masterfrom
Closed
Conversation
second merge
Contributor
💚 Build Succeeded |
pavel06081991
approved these changes
Oct 3, 2018
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
LGTM but please fix comments
rashidkpc
added
the
Team:Presentation
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
clintandrewhall
left a comment
clintandrewhall
left a comment
There was a problem hiding this comment.
My comments are below.
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
please check all places where you disable eslint rules. When you disable some line you should add name of rule you disable
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
@clintandrewhall please review one more time |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
This was referenced Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translate canvas public lib
#23222