[ML] AIOps: Registering embeddables and uiActions synchronously#268001
Merged
jgowdyelastic merged 4 commits intoMay 8, 2026
Merged
Conversation
jgowdyelastic
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
approved these changes
May 8, 2026
| import { registerCases } from './cases/register_cases'; | ||
| import { canUseAiops } from './capabilities'; | ||
|
|
||
| export type AiopsCoreSetup = CoreSetup<AiopsPluginStartDeps, AiopsPluginStart>; |
Contributor
There was a problem hiding this comment.
what do you think of moving it to x-pack/platform/plugins/shared/aiops/public/types/index.ts?
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
May 8, 2026
…tic#268001) Resolves potential the race conditions by registering embeddables and actions synchronously. The capabilities check is moved from registration time to the action's `isCompatible` method and embeddable's `buildEmbeddable` method.
js-jankisalvi
pushed a commit
to js-jankisalvi/kibana
that referenced
this pull request
May 12, 2026
…tic#268001) Resolves potential the race conditions by registering embeddables and actions synchronously. The capabilities check is moved from registration time to the action's `isCompatible` method and embeddable's `buildEmbeddable` method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves potential the race conditions by registering embeddables and actions synchronously.
The capabilities check is moved from registration time to the action's
isCompatiblemethod and embeddable'sbuildEmbeddablemethod.