Skip to content

[Background search] Migrate custom SplitButton to EuiSplitButton#267447

Merged
AlexGPlay merged 3 commits intoelastic:mainfrom
AlexGPlay:267444-replace-split-button
May 5, 2026
Merged

[Background search] Migrate custom SplitButton to EuiSplitButton#267447
AlexGPlay merged 3 commits intoelastic:mainfrom
AlexGPlay:267444-replace-split-button

Conversation

@AlexGPlay
Copy link
Copy Markdown
Contributor

@AlexGPlay AlexGPlay commented May 4, 2026 •
edited
Loading

Summary

Closes #267444

When background search was first implemented we didn't have a split button in EUI so we had to build our own. Now there's already one in EUI so we can just use it instead.

Before After
image image
image image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 4, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
unifiedSearch 1168 1165 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 311.1KB 309.9KB -1.2KB

History

@AlexGPlay AlexGPlay changed the title Replace custom split button with eui [Background search] Migrate custom SplitButton to EuiSplitButton May 4, 2026
@AlexGPlay AlexGPlay self-assigned this May 4, 2026
@AlexGPlay AlexGPlay added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// Feature:BackgroundSearch Background search feature used in Discover, Dashboard, etc. labels May 4, 2026
@AlexGPlay AlexGPlay marked this pull request as ready for review May 4, 2026 14:39
@AlexGPlay AlexGPlay requested a review from a team as a code owner May 4, 2026 14:39
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

infra-vault-gh-plugin-prod Bot commented May 4, 2026

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

ThomThomson
ThomThomson approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM. Just a simple component swap. Will there be a followup PR for removing the custom SplitButton implementation?

@AlexGPlay
Copy link
Copy Markdown
Contributor Author

AlexGPlay commented May 5, 2026

Presentation team changes LGTM. Just a simple component swap. Will there be a followup PR for removing the custom SplitButton implementation?

I was thinking about that too but there are 2 other places using it right now:

  • src/platform/plugins/shared/navigation/public/top_nav_menu/top_nav_menu_item.tsx
  • src/platform/packages/private/kbn-split-button/src/split_button_with_notification.tsx

@AlexGPlay AlexGPlay merged commit a8c8ebc into elastic:main May 5, 2026
68 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request May 5, 2026
@mbondyra
Merge commit '6fd683609eb6dee81f242f8ff6951edbe3bfd66c' into agent_bu…
7e04d4f 
…ilder_new_vis_attachment

* commit '6fd683609eb6dee81f242f8ff6951edbe3bfd66c': (226 commits)
  Remove Model Author group-by option from external inference endpoints (elastic#264761)
  [Streams][Streamlang] Align ES|QL condition transpiler with Painless on null propagation (elastic#264751)
  chore(axios,workflows-eng): remove axios from workflows connector utils (elastic#267512)
  [failed-test-reporter] avoid opening issues for scout env failures (elastic#267649)
  [kbn-api-contracts] Detect request-body additionalProperties:false tightening (elastic#267546)
  [main] Sync bundled packages with Package Storage (elastic#267644)
  Centralize phase colors and descriptions (elastic#266680)
  [Unified Waterfall] Add "Scroll to origin" button  (elastic#266594)
  [APM] Add alert and SLO badges to the service map embeddable (elastic#266360)
  [CI] Speed up telemetry_check by pre-filtering to collector files (elastic#265978)
  [Discover] Address flaky large CSV test (elastic#266642)
  avoid passing unrelated props within integration card icon component conditional render (elastic#266569)
  [Cases][Templates] Extend cases search by template field label (elastic#266414)
  [Background search] Migrate custom SplitButton to EuiSplitButton (elastic#267447)
  [i18n] Report translation coverage during integrate (elastic#264124)
  [api-docs] 2026-05-05 Daily api_docs build (elastic#267639)
  [Scout] Update test config manifests (elastic#267636)
  [content list] Add saved object provider services (elastic#266428)
  [Fleet] Otel UI add health and implement it in OTelComponentDetail (elastic#267292)
  Update dependency msw to v2.13.4 (main) (elastic#266770)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@akowalska622 akowalska622 akowalska622 approved these changes

Assignees

@AlexGPlay AlexGPlay

Labels

backport:skip This PR does not require backporting Feature:BackgroundSearch Background search feature used in Discover, Dashboard, etc. release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Background search] Replace Kibana SplitButton with EuiSplitButton

4 participants

@AlexGPlay @kibanamachine @ThomThomson @akowalska622