Remove Model Author group-by option from external inference endpoints by tutelaris · Pull Request #264761 · elastic/kibana

tutelaris · 2026-04-21T15:45:53Z

Removes the "Model Author" group-by option from the inference endpoints
UI and cleans up all associated code and tests.

Changes

types.ts: Removed GroupByOptions.Model enum member and narrowed
GroupByViewOptions to GroupByOptions.Service only.
group_by_select.tsx: Removed the "Model Author" option from the
group-by select dropdown.
tabular_page.tsx: Changed DEFAULT_GROUP_BY from
GroupByOptions.Model to GroupByOptions.None and removed the
model_id URL param case.
group_by.ts: Deleted GroupByModelReducer, ModelsGroupBySort,
and all associated model-grouping logic including the
UNKNOWN_MODEL_ID_FALLBACK constant.
Tests: Removed all test cases that exercised the now-deleted model
grouping behavior across group_by_select.test.tsx,
group_by.test.ts, use_grouped_data.test.ts,
use_groups_accordion_toggle_state.test.ts, and
tabular_page.test.tsx.

…to "Model ID" on the external inference page Closes elastic/search-team#14077 Automatically implemented by Claude Code from elastic/search-team#14077 Co-authored-by: claude-code[bot] <claude-code[bot]@users.noreply.github.com>

macroscopeapp · 2026-04-21T15:47:36Z

Approvability

Verdict: Needs human review

This PR removes a user-facing feature (Model Author grouping option) and changes the default grouping behavior. While the changes are clean and the author owns the relevant code, removing user-facing functionality warrants human review to confirm intent.

^{You can customize Macroscope's approvability policy. Learn more.}

… dropdown on external inference page Remove the "Model ID" grouping option from the GroupBySelect component, leaving only "None" and "Service". Update the default groupBy from Model to None in tabular_page.tsx and remove the Model case from initializeGroupBy. Update tests accordingly.

…Model group-by option Remove `GroupByOptions.Model` from the enum and `GroupByViewOptions` type, delete `GroupByModelReducer`, `ModelsGroupBySort`, and their now-unused imports (`getModelId`, `KNOWN_MODEL_GROUPS`, `ELASTIC_GROUP_ID`, `isInferenceEndpointWithDisplayCreatorMetadata`, `UNKNOWN_MODEL_ID_FALLBACK`), and update/remove all tests that exercised Model-specific grouping behaviour.

elasticmachine · 2026-04-22T15:37:21Z

💔 Build Failed

Buildkite Build
Commit: cdf003b

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should disable delete action for preconfigured endpoints in grouped tables
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should disable delete action for preconfigured endpoints in grouped tables
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should display accordions with tables for model groups
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should display accordions with tables for model groups
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should enable delete action for user-defined endpoints in grouped tables
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should enable delete action for user-defined endpoints in grouped tables
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should have expected endpoint table columns
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should have expected endpoint table columns
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should show expected group labels and endpoint counts
[job] [logs] Jest Tests #1 / When the tabular page is loaded group by models should show expected group labels and endpoint counts

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [45d55ef]

History

💔 Build #431649 failed 3aed727
💔 Build #431612 failed 34d8c4b
💛 Build #431548 was flaky 927dbe2

cc @tutelaris

seialkali

I've tested this locally and it's working as expected. Looks like there's a couple of tests still needing to be removed so I'll approve as soon as that's updated and CI passes.

The `GroupByOptions.Model` option was removed from the codebase but the corresponding test suite in `tabular_page.test.tsx` was left behind, causing 5 test failures in CI. Remove the entire "group by models" describe block.

kibanamachine · 2026-05-05T02:19:39Z

💚 Build Succeeded

Buildkite Build
Commit: 5f3965a

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`searchInferenceEndpoints`	240	239	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`searchInferenceEndpoints`	218.8KB	217.1KB	-1.7KB

History

💚 Build #437769 succeeded 9d69532
💔 Build #435931 failed 68f2107
💔 Build #435877 failed 82667d1

cc @tutelaris

kibanamachine · 2026-05-05T08:25:39Z

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25365763453

…ilder_new_vis_attachment * commit '6fd683609eb6dee81f242f8ff6951edbe3bfd66c': (226 commits) Remove Model Author group-by option from external inference endpoints (elastic#264761) [Streams][Streamlang] Align ES|QL condition transpiler with Painless on null propagation (elastic#264751) chore(axios,workflows-eng): remove axios from workflows connector utils (elastic#267512) [failed-test-reporter] avoid opening issues for scout env failures (elastic#267649) [kbn-api-contracts] Detect request-body additionalProperties:false tightening (elastic#267546) [main] Sync bundled packages with Package Storage (elastic#267644) Centralize phase colors and descriptions (elastic#266680) [Unified Waterfall] Add "Scroll to origin" button (elastic#266594) [APM] Add alert and SLO badges to the service map embeddable (elastic#266360) [CI] Speed up telemetry_check by pre-filtering to collector files (elastic#265978) [Discover] Address flaky large CSV test (elastic#266642) avoid passing unrelated props within integration card icon component conditional render (elastic#266569) [Cases][Templates] Extend cases search by template field label (elastic#266414) [Background search] Migrate custom SplitButton to EuiSplitButton (elastic#267447) [i18n] Report translation coverage during integrate (elastic#264124) [api-docs] 2026-05-05 Daily api_docs build (elastic#267639) [Scout] Update test config manifests (elastic#267636) [content list] Add saved object provider services (elastic#266428) [Fleet] Otel UI add health and implement it in OTelComponentDetail (elastic#267292) Update dependency msw to v2.13.4 (main) (elastic#266770) ...

kibanamachine · 2026-05-05T08:34:25Z

💔 All backports failed

Status	Branch	Result
❌	9.4	Backport failed because of merge conflicts You might need to backport the following PRs to 9.4: - Add aria-labelledby to Console Config settings controls (#265207) - [Search] [Inference Endpoints] Small UI improvements to Add/Edit endpoint flyout (#262143) - Move all i18n inline (#262363)

Manual backport

To create the backport manually run:

node scripts/backport --pr 264761

Questions ?

Please refer to the Backport tool documentation

tutelaris requested a review from a team as a code owner April 21, 2026 15:45

tutelaris added the Team:Search label Apr 21, 2026

tutelaris self-assigned this Apr 21, 2026

tutelaris requested a review from sphilipse April 21, 2026 15:45

saikatsarkar056 added v9.4.0 v9.5.0 release_note:fix backport:version Backport to applied version labels labels Apr 21, 2026

saikatsarkar056 changed the title ~~auto-implement: [Inference Endpoints] Rename "Model Author" grouping to "Model ID" on the external inference page~~ auto-implement: [Inference Endpoints] Remove the "Model Author" group-by option from the external inference page Apr 21, 2026

tutelaris and others added 2 commits April 21, 2026 17:56

Merge branch 'main' into auto-implement/issue-14077

cdf003b

seialkali reviewed Apr 22, 2026

View reviewed changes

fix: remove obsolete "group by models" tests from tabular_page

82667d1

The `GroupByOptions.Model` option was removed from the codebase but the corresponding test suite in `tabular_page.test.tsx` was left behind, causing 5 test failures in CI. Remove the entire "group by models" describe block.

tutelaris changed the title ~~auto-implement: [Inference Endpoints] Remove the "Model Author" group-by option from the external inference page~~ Remove Model Author group-by option from external inference endpoints Apr 29, 2026

saikatsarkar056 and others added 3 commits April 29, 2026 13:19

Merge branch 'main' into auto-implement/issue-14077

68f2107

fix(i18n): remove orphaned model group-by translation keys

9d69532

Merge branch 'main' into auto-implement/issue-14077

5f3965a

saikatsarkar056 enabled auto-merge (squash) May 5, 2026 01:26

seialkali approved these changes May 5, 2026

View reviewed changes

saikatsarkar056 merged commit 6fd6836 into elastic:main May 5, 2026
25 checks passed

saikatsarkar056 added backport:skip This PR does not require backporting and removed v9.4.0 labels May 5, 2026

saikatsarkar056 removed the backport:version Backport to applied version labels label May 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Model Author group-by option from external inference endpoints#264761

Remove Model Author group-by option from external inference endpoints#264761
saikatsarkar056 merged 8 commits intoelastic:mainfrom
tutelaris:auto-implement/issue-14077

tutelaris commented Apr 21, 2026 •

edited by kibanamachine

Loading

Uh oh!

macroscopeapp Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

elasticmachine commented Apr 22, 2026 •

edited

Loading

Uh oh!

seialkali left a comment

Uh oh!

kibanamachine commented May 5, 2026

Uh oh!

Uh oh!

kibanamachine commented May 5, 2026

Uh oh!

kibanamachine commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

tutelaris commented Apr 21, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

macroscopeapp Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

elasticmachine commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

seialkali left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 5, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Uh oh!

kibanamachine commented May 5, 2026

Uh oh!

kibanamachine commented May 5, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tutelaris commented Apr 21, 2026 •

edited by kibanamachine

Loading

macroscopeapp Bot commented Apr 21, 2026 •

edited

Loading

elasticmachine commented Apr 22, 2026 •

edited

Loading