[9.4] fix(zod): adopt upstream lazy-bind memory optimization (colinhacks/zod#5897) (#266343)#266401
Merged
gsoldevila merged 4 commits intoelastic:9.4from Apr 29, 2026
Merged
Conversation
Replaces `Object.assign(proto, methods)` in the `_initProto` helper
(added by the previous shadow-proto patch) with a `Object.defineProperty`
getter loop:
for (const [k, fn] of Object.entries(methods)) {
Object.defineProperty(proto, k, {
get() { return fn.bind(this); },
configurable: true,
enumerable: false,
});
}
When a method is accessed on an instance (e.g. `schema.optional`), the
getter returns a copy bound to `this`, so detached calls — including
destructuring and variable extraction — continue to work:
const opt = schema.optional;
opt(); // previously threw; now works correctly
The memory benefits of the shadow-proto approach are fully preserved:
builder methods are still not own properties, so V8 keeps schema
instances in fast-property mode.
Adds a behavioural unit test in `@kbn/zod` that covers the main
detached-call scenarios and documents the known trade-off (each getter
access allocates a new bound function).
Made-with: Cursor
gsoldevila
added
backport
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gsoldevila
added
ci:build-cloud-image
and removed
Team:Core
Member
Author
|
/ci |
jesuswr
approved these changes
Apr 29, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation
Made with Cursor