[OAS][Detection Engine] Clean up remaining errors#266228
[OAS][Detection Engine] Clean up remaining errors#266228yctercero merged 15 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
| /** | ||
| * Elasticsearch update by query response | ||
| */ | ||
| export const SetAlertAssigneesResponse = lazySchema(() => z.object({}).catchall(z.unknown())); |
There was a problem hiding this comment.
@PhilippeOberti the scripts keep adding this in. Could you confirm this is ok?
There was a problem hiding this comment.
I'm honestly not sure if it's ok, but looking at a neighbor's file, I see this for alert tags:
export const SetAlertTagsResponse = lazySchema(() => z.object({}).catchall(z.unknown()));Introduced in this recent PR. So I'm guessing the answer is yes it's ok do to it?
There was a problem hiding this comment.
There is this same example for alert status:
export const SetAlertsStatusResponse = lazySchema(() => z.object({}).catchall(z.unknown()));There was a problem hiding this comment.
FYI lazySchema() helper was introduced in @kbn/openapi-generator in #264125. This is an action item to mitigate significantly increased Kibana idle memory consumption.
Please let me know if some functionality doesn't work because of lazySchema() helper. The helper should be transparent for functionality. And our tests didn't reveal issues.
There was a problem hiding this comment.
@PhilippeOberti I'm waiting on green to merge after confirming with Maxim. Let me know if you feel any changes should be made and I'm happy to follow up.
dhurley14
left a comment
There was a problem hiding this comment.
DE changes lgtm but I have the same question for the SetAlertAssigneesResponse catchall. My initial feelings is it should be a little more specific perhaps? cc: @PhilippeOberti
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
cc @yctercero |
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/25180470889 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Summary
This PR updates OpenAPI (OAS) documentation for HTTP APIs (api/detection_engine, api/lists, api/exception_lists): clearer descriptions, summaries, examples (request/response/params), and deprecation notes where routes are legacy or migration-related.
Scope: spec / documentation only. It does not change request or response validation schemas, route handlers, or runtime behavior—only how those routes are described in the OAS layer.
Ran and found no more errors: