Fix OAS validation errors in entity analytics privilege monitoring APIs && Risk Score APIs #265470
Fix OAS validation errors in entity analytics privilege monitoring APIs && Risk Score APIs #265470CAWilson94 merged 14 commits intoelastic:mainfrom
Conversation
- Added detailed examples for error responses in the monitoring engine initialization and scheduling endpoints, including `InitMonitoringEngineError` and `ScheduleMonitoringEngineConflict`. - Updated privilege response examples to use the `examples` field instead of `example` for consistency across the API documentation. - Included CSV upload request and response examples for bulk user operations, improving clarity on expected input and output formats. - Enhanced parameter descriptions for user deletion and update operations to specify the document ID context.
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
…ponse examples - Added examples for Task Manager unavailability and error responses in `engine_cleanup_route`, `engine_configure_saved_object_route`, and `engine_schedule_now_route` schemas. - Enhanced documentation for better clarity on expected responses, including specific error messages and status codes. - Updated bundled OpenAPI schema files to reflect these changes for both ESS and serverless environments.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @CAWilson94 |
hammad-nasir-elastic
left a comment
There was a problem hiding this comment.
Core changes LGTM
spong
left a comment
There was a problem hiding this comment.
Single Security Solution change in quickstart_client.gen.ts LGTM 👍
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
cc @CAWilson94 |
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24912465854 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…Is && Risk Score APIs (elastic#265470)
…Is && Risk Score APIs (elastic#265470)
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Adds missing
examplesanddescriptionfields to the privilege monitoring OpenAPI schemas to resolve 7 OAS validation errors (down to 0 forapi/entity_analyticson both traditional and serverless).Changes
engine/init— added example for500responseengine/schedule_now— added example for409conflict responsemonitoring/privileges— fixedexample:→examples:(wrong key) on200responseusers/_csv— added examples formultipart/form-datarequest body and200responseusers/{id}delete + update — addeddescriptionto theidpath parameterAlso regenerates the bundled ESS and serverless schemas and updates
oas_docs/output/kibana.yaml/kibana.serverless.yaml.Testing and Validation:
I used the node script initially, and followed up with the
'validate-oas'skill in cursor, which then gave me some extra steps to share:OAS (entity analytics + privileged user monitoring) Client Commands
Node: Use v22.22.0 (Kibana scripts reject other versions), e.g.
nvm use 22if you use nvm.(Optional but CI-like) If your branch changes routes or the generated spec might be stale:
yarn kbn bootstrap--include-pathlist in.codex/skills/validate-oas/SKILL.md, and add--include-path /api/entity_analyticsif you need that area in the snap):node scripts/capture_oas_snapshot… (see the skill for the full list)cd oas_docs && make api-docsScoped validate (fast pass/fail for your APIs):
Using the
validate-oasskill: