Skip to content

[Inference] Update Feature Settings, External Inference doc links and UI text#265633

Merged
lcawl merged 9 commits into
elastic:mainfrom
lcawl:model-management-review
Apr 30, 2026
Merged

[Inference] Update Feature Settings, External Inference doc links and UI text#265633
lcawl merged 9 commits into
elastic:mainfrom
lcawl:model-management-review

Conversation

@lcawl
Copy link
Copy Markdown
Contributor

@lcawl lcawl commented Apr 24, 2026

Summary

This PR adds https://www.elastic.co/docs/explore-analyze/ai-features/manage-access-to-ai-assistant to the doc link service and uses it on the Feature Settings page.
Relates to elastic/docs-content#6122

I've also edited one string in that app that seemed unclear.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:Search backport:version Backport to applied version labels v9.5.0 labels Apr 24, 2026
@lcawl lcawl marked this pull request as ready for review April 24, 2026 23:27
@lcawl lcawl requested review from a team as code owners April 24, 2026 23:27
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 24, 2026

Approvability

Verdict: Needs human review

Low-risk changes adding documentation links and updating UI copy text. However, all modified files are owned by other teams (@elastic/docs, @elastic/search-kibana) and the designated code owners should review.

You can customize Macroscope's approvability policy. Learn more.

@lcawl lcawl changed the title [Inference] Update Feature Settings doc link and UI text [Inference] Update Feature Settings, External Inference doc links and UI text Apr 28, 2026
@lcawl lcawl enabled auto-merge (squash) April 28, 2026 23:53
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #8 / SelectInterval calls onChange when clicked

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 98.9KB 99.0KB +147.0B
searchInferenceEndpoints 219.4KB 219.3KB -18.0B
total +129.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 521.8KB 521.9KB +147.0B
searchInferenceEndpoints 8.7KB 8.9KB +206.0B
total +353.0B

History

@@ -228,8 +228,7 @@ export const DefaultModelSection: React.FC<Props> = ({ defaultModelSettings }) =
: i18n.translate(
'xpack.searchInferenceEndpoints.settings.defaultModel.allowOtherModels.description',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a new i18n message id for allowOtherModels help text since the defaultMessage meaning shifted; keeping the old id can leave non-English strings on the old wording. After changing the id, run node scripts/i18n_check --fix.

Copy link
Copy Markdown
Member

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit b26091f into elastic:main Apr 30, 2026
42 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25156947156

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
9.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.4:
- Move all i18n inline (#262363)

Manual backport

To create the backport manually run:

node scripts/backport --pr 265633

Questions ?

Please refer to the Backport tool documentation

@lcawl
Copy link
Copy Markdown
Contributor Author

lcawl commented Apr 30, 2026

💚 All backports created successfully

Status Branch Result
9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the model-management-review branch April 30, 2026 14:56
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 4, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

lcawl added a commit that referenced this pull request May 4, 2026
…ks and UI text (#265633) (#266696)

# Backport

This will backport the following commits from `main` to `9.4`:
- [[Inference] Update Feature Settings, External Inference doc links and
UI text (#265633)](#265633)

<!--- Backport version: 11.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2026-04-30T09:03:45Z","message":"[Inference]
Update Feature Settings, External Inference doc links and UI text
(#265633)","sha":"b26091f5851c0686b52935e753aba0a3c50bd31c","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Search","backport:version","v9.4.0","v9.5.0"],"title":"[Inference]
Update Feature Settings, External Inference doc links and UI
text","number":265633,"url":"https://github.com/elastic/kibana/pull/265633","mergeCommit":{"message":"[Inference]
Update Feature Settings, External Inference doc links and UI text
(#265633)","sha":"b26091f5851c0686b52935e753aba0a3c50bd31c"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/265633","number":265633,"mergeCommit":{"message":"[Inference]
Update Feature Settings, External Inference doc links and UI text
(#265633)","sha":"b26091f5851c0686b52935e753aba0a3c50bd31c"}}]}]
BACKPORT-->

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.4.0 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants