[9.4] [dashboard] unskip platform/plugins/private/links/public/components/editor tests (#262904)#264206
Merged
Merged
Conversation
…ditor tests (elastic#262904) Closes elastic#253303 Test skipped because it some times timed out (took over 5000ms). The test is slow because it renders a lazy loaded component. This PR resolves the lazy load by moving `DashboardNavigationOptionsEditor` into a package. Unfortunately, this required creating 3 packages, `schema`, `common`, and a `components` package. The tests were originally added in elastic#211041. elastic#211041 fixed a bug but did not resolve the code smell that caused the bug. The problem is that `options` state is getting stored at 2 different levels in 2 different `useStates`. This PR resolves that code smell by removing LinkOption component and moving it into `LinkEditor` and then removing duplicated `linkOptions` state. Original test run (with lazy load component). Notice how first test case takes over a second because lazy load component has to load. <img width="1371" height="193" alt="Screenshot 2026-04-13 at 3 32 25 PM" src="https://github.com/user-attachments/assets/0a9a58f6-b8ee-488d-ad9b-116467eb14a1" /> This PR test run (with component in package - so no lazy loading needed). <img width="1293" height="188" alt="Screenshot 2026-04-13 at 3 34 26 PM" src="https://github.com/user-attachments/assets/5ff05378-ebe7-461f-a1e2-ecae57818944" /> --------- Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e774326)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation