[dashboard] unskip platform/plugins/private/links/public/components/editor tests#262904
Open
nreese wants to merge 21 commits intoelastic:mainfrom
Open
[dashboard] unskip platform/plugins/private/links/public/components/editor tests#262904nreese wants to merge 21 commits intoelastic:mainfrom
nreese wants to merge 21 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
This reverts commit e4ac710.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
This reverts commit 7091dd4.
…nk_editor.tsx Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>
Contributor
Author
|
/ci |
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
Contributor
Author
|
/ci |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Contributor
Author
|
/ci |
nreese
added
the
Team:Presentation
nreese
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253303
Test skipped because it some times timed out (took over 5000ms). The test is slow because it renders a lazy loaded component. This PR resolves the lazy load by moving
DashboardNavigationOptionsEditorinto a package. Unfortunately, this required creating 3 packages,schema,common, and acomponentspackage.The tests were originally added in #211041. #211041 fixed a bug but did not resolve the code smell that caused the bug. The problem is that
optionsstate is getting stored at 2 different levels in 2 differentuseStates. This PR resolves that code smell by removing LinkOption component and moving it intoLinkEditorand then removing duplicatedlinkOptionsstate.Original test run (with lazy load component). Notice how first test case takes over a second because lazy load component has to load.
This PR test run (with component in package - so no lazy loading needed).
