Skip to content

[9.4] Fix @elastic/eui/prefer-eui-icon-tip lint violations (#263526)#264173

Merged
kibanamachine merged 1 commit intoelastic:9.4from
kibanamachine:backport/9.4/pr-263526
Apr 17, 2026
Merged

[9.4] Fix @elastic/eui/prefer-eui-icon-tip lint violations (#263526)#264173
kibanamachine merged 1 commit intoelastic:9.4from
kibanamachine:backport/9.4/pr-263526

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.4:

Questions ?

Please refer to the Backport tool documentation

Closes: elastic#263525

Replace `<EuiToolTip><EuiIcon /></EuiToolTip>` with `<EuiIconTip>` in
three files to satisfy the `@elastic/eui/prefer-eui-icon-tip` ESLint
rule. `EuiIconTip` provides better accessibility semantics for assistive
technologies out of the box.

- **`query_results_grid.tsx`** — group key column header icon
- **`filed_info.tsx`** — failed docs errors column tooltip
- **`unhealthy_tooltip.tsx`** — monitor unhealthy status icon (preserves
existing `aria-label` and `data-test-subj`)

Before:
```tsx
<EuiToolTip content={tooltipText}>
  <EuiIcon type="question" size="s" color="subdued" />
</EuiToolTip>
```

After:
```tsx
<EuiIconTip content={tooltipText} type="question" size="s" color="subdued" />
```

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `ci-stats.kibana.dev`
> - Triggering command:
`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node
/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn
bootstrap` (dns block)
> - Triggering command:
`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node
/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node
scripts/yarn_install_scripts.js run /lib64/ld-linux-x86-64.so.2 b/li��`
(dns block)
> - Triggering command:
`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node
/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn
bootstrap ldd s/li��` (dns block)
> - `clients3.google.com`
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana
v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns
block)
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack x86-64.so.2 s/li��` (dns block)
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd nibr�� ]) exit(3);
else if (a[i] &gt; b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local
user.name dd x86-64.so.2 nibr��` (dns block)
> - `detectportal.firefox.com`
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana
v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns
block)
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack x86-64.so.2 s/li��` (dns block)
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd nibr�� ]) exit(3);
else if (a[i] &gt; b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local
user.name dd x86-64.so.2 nibr��` (dns block)
> - `google.com`
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana
v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns
block)
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack x86-64.so.2 s/li��` (dns block)
> - Triggering command:
`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon
run :build-webpack ldd nibr�� ]) exit(3);
else if (a[i] &gt; b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local
user.name dd x86-64.so.2 nibr��` (dns block)
> - `googlechromelabs.github.io`
> - Triggering command:
`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node
/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js
.git/copilot-hoo/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3
/lib/ld-linux.so.2 b/li��` (dns block)
> - `iojs.org`
> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s
REDACTED -o -` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/elastic/kibana/settings/copilot/coding_agent)
(admins only)
>
> </details>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
(cherry picked from commit 7d030bc)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Apr 17, 2026
@kibanamachine kibanamachine enabled auto-merge (squash) April 17, 2026 17:29
@kibanamachine kibanamachine merged commit 5047295 into elastic:9.4 Apr 17, 2026
19 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #107 / aiops change point detection UI allows change point selection for detailed view

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alertingVTwo 631.5KB 631.4KB -40.0B
datasetQuality 523.2KB 523.2KB -23.0B
synthetics 1.1MB 1.1MB -23.0B
total -86.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants