Fix @elastic/eui/prefer-eui-icon-tip lint violations#263526
Merged
Conversation
6 tasks
…fer-eui-icon-tip lint violations Agent-Logs-Url: https://github.com/elastic/kibana/sessions/355db501-c5f5-45ce-808f-13576afdd97c Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix lint violations for @elastic_eui_prefer-eui-icon-tip
Fix Apr 15, 2026
@elastic/eui/prefer-eui-icon-tip lint violations
Contributor
|
/ci |
alexwizp
approved these changes
Apr 15, 2026
alexwizp
added
Project:Accessibility
release_note:skip
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
flash1293
approved these changes
Apr 16, 2026
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Data quality change is looking good to me.
Contributor
|
@elastic/actionable-obs-team, @elastic/rna-project-team please review |
Contributor
|
@elasticmachine run docs-build |
Contributor
|
@elasticmachine run docs-build |
Contributor
|
/ci |
Contributor
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/24577353822 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @alexwizp @Copilot |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 17, 2026
Closes: elastic#263525 Replace `<EuiToolTip><EuiIcon /></EuiToolTip>` with `<EuiIconTip>` in three files to satisfy the `@elastic/eui/prefer-eui-icon-tip` ESLint rule. `EuiIconTip` provides better accessibility semantics for assistive technologies out of the box. - **`query_results_grid.tsx`** — group key column header icon - **`filed_info.tsx`** — failed docs errors column tooltip - **`unhealthy_tooltip.tsx`** — monitor unhealthy status icon (preserves existing `aria-label` and `data-test-subj`) Before: ```tsx <EuiToolTip content={tooltipText}> <EuiIcon type="question" size="s" color="subdued" /> </EuiToolTip> ``` After: ```tsx <EuiIconTip content={tooltipText} type="question" size="s" color="subdued" /> ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run /lib64/ld-linux-x86-64.so.2 b/li��` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap ldd s/li��` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack x86-64.so.2 s/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd nibr�� ]) exit(3); else if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local user.name dd x86-64.so.2 nibr��` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack x86-64.so.2 s/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd nibr�� ]) exit(3); else if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local user.name dd x86-64.so.2 nibr��` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack x86-64.so.2 s/li��` (dns block) > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd nibr�� ]) exit(3); else if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local user.name dd x86-64.so.2 nibr��` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js .git/copilot-hoo/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3 /lib/ld-linux.so.2 b/li��` (dns block) > - `iojs.org` > - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> (cherry picked from commit 7d030bc)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 17, 2026
#264173) # Backport This will backport the following commits from `main` to `9.4`: - [Fix `@elastic/eui/prefer-eui-icon-tip` lint violations (#263526)](#263526) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-17T17:09:11Z","message":"Fix `@elastic/eui/prefer-eui-icon-tip` lint violations (#263526)\n\nCloses: https://github.com/elastic/kibana/issues/263525\n\nReplace `<EuiToolTip><EuiIcon /></EuiToolTip>` with `<EuiIconTip>` in\nthree files to satisfy the `@elastic/eui/prefer-eui-icon-tip` ESLint\nrule. `EuiIconTip` provides better accessibility semantics for assistive\ntechnologies out of the box.\n\n- **`query_results_grid.tsx`** — group key column header icon\n- **`filed_info.tsx`** — failed docs errors column tooltip\n- **`unhealthy_tooltip.tsx`** — monitor unhealthy status icon (preserves\nexisting `aria-label` and `data-test-subj`)\n\nBefore:\n```tsx\n<EuiToolTip content={tooltipText}>\n <EuiIcon type=\"question\" size=\"s\" color=\"subdued\" />\n</EuiToolTip>\n```\n\nAfter:\n```tsx\n<EuiIconTip content={tooltipText} type=\"question\" size=\"s\" color=\"subdued\" />\n```\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run /lib64/ld-linux-x86-64.so.2 b/li\u0004\u0018`\n(dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap ldd s/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\n.git/copilot-hoo/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3\n/lib/ld-linux.so.2 b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"7d030bc8fd302124d91b5f28a2d8d3cc30c122d1","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.4"],"title":"Fix `@elastic/eui/prefer-eui-icon-tip` lint violations","number":263526,"url":"https://github.com/elastic/kibana/pull/263526","mergeCommit":{"message":"Fix `@elastic/eui/prefer-eui-icon-tip` lint violations (#263526)\n\nCloses: https://github.com/elastic/kibana/issues/263525\n\nReplace `<EuiToolTip><EuiIcon /></EuiToolTip>` with `<EuiIconTip>` in\nthree files to satisfy the `@elastic/eui/prefer-eui-icon-tip` ESLint\nrule. `EuiIconTip` provides better accessibility semantics for assistive\ntechnologies out of the box.\n\n- **`query_results_grid.tsx`** — group key column header icon\n- **`filed_info.tsx`** — failed docs errors column tooltip\n- **`unhealthy_tooltip.tsx`** — monitor unhealthy status icon (preserves\nexisting `aria-label` and `data-test-subj`)\n\nBefore:\n```tsx\n<EuiToolTip content={tooltipText}>\n <EuiIcon type=\"question\" size=\"s\" color=\"subdued\" />\n</EuiToolTip>\n```\n\nAfter:\n```tsx\n<EuiIconTip content={tooltipText} type=\"question\" size=\"s\" color=\"subdued\" />\n```\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run /lib64/ld-linux-x86-64.so.2 b/li\u0004\u0018`\n(dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap ldd s/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\n.git/copilot-hoo/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3\n/lib/ld-linux.so.2 b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"7d030bc8fd302124d91b5f28a2d8d3cc30c122d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/263526","number":263526,"mergeCommit":{"message":"Fix `@elastic/eui/prefer-eui-icon-tip` lint violations (#263526)\n\nCloses: https://github.com/elastic/kibana/issues/263525\n\nReplace `<EuiToolTip><EuiIcon /></EuiToolTip>` with `<EuiIconTip>` in\nthree files to satisfy the `@elastic/eui/prefer-eui-icon-tip` ESLint\nrule. `EuiIconTip` provides better accessibility semantics for assistive\ntechnologies out of the box.\n\n- **`query_results_grid.tsx`** — group key column header icon\n- **`filed_info.tsx`** — failed docs errors column tooltip\n- **`unhealthy_tooltip.tsx`** — monitor unhealthy status icon (preserves\nexisting `aria-label` and `data-test-subj`)\n\nBefore:\n```tsx\n<EuiToolTip content={tooltipText}>\n <EuiIcon type=\"question\" size=\"s\" color=\"subdued\" />\n</EuiToolTip>\n```\n\nAfter:\n```tsx\n<EuiIconTip content={tooltipText} type=\"question\" size=\"s\" color=\"subdued\" />\n```\n\n> [!WARNING]\n>\n> <details>\n> <summary>Firewall rules blocked me from connecting to one or more\naddresses (expand for details)</summary>\n>\n> #### I tried to connect to the following addresses, but was blocked by\nfirewall rules:\n>\n> - `ci-stats.kibana.dev`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap` (dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\nscripts/yarn_install_scripts.js run /lib64/ld-linux-x86-64.so.2 b/li\u0004\u0018`\n(dns block)\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn\nbootstrap ldd s/li\u0004\u0018` (dns block)\n> - `clients3.google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `detectportal.firefox.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `google.com`\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana\nv22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man` (dns\nblock)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack x86-64.so.2 s/li\u0004\u0018` (dns block)\n> - Triggering command:\n`/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\n/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon\nrun :build-webpack ldd nibr\u0004\u0018 ]) exit(3);\nelse if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local\nuser.name dd x86-64.so.2 nibr\u0004\u0018` (dns block)\n> - `googlechromelabs.github.io`\n> - Triggering command:\n`/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node\n/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js\n.git/copilot-hoo/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3\n/lib/ld-linux.so.2 b/li\u0004\u0018` (dns block)\n> - `iojs.org`\n> - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s\nREDACTED -o -` (dns block)\n>\n> If you need me to access, download, or install something from one of\nthese locations, you can either:\n>\n> - Configure [Actions setup\nsteps](https://gh.io/copilot/actions-setup-steps) to set up my\nenvironment, which run before the firewall is enabled\n> - Add the appropriate URLs or hosts to the custom allowlist in this\nrepository's [Copilot coding agent\nsettings](https://github.com/elastic/kibana/settings/copilot/coding_agent)\n(admins only)\n>\n> </details>\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"7d030bc8fd302124d91b5f28a2d8d3cc30c122d1"}},{"branch":"9.3","label":"v9.3.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #263525
Replace
<EuiToolTip><EuiIcon /></EuiToolTip>with<EuiIconTip>in three files to satisfy the@elastic/eui/prefer-eui-icon-tipESLint rule.EuiIconTipprovides better accessibility semantics for assistive technologies out of the box.query_results_grid.tsx— group key column header iconfiled_info.tsx— failed docs errors column tooltipunhealthy_tooltip.tsx— monitor unhealthy status icon (preserves existingaria-labelanddata-test-subj)Before:
After:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ci-stats.kibana.dev/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap(dns block)/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run /lib64/ld-linux-x86-64.so.2 b/li��(dns block)/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap ldd s/li��(dns block)clients3.google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack x86-64.so.2 s/li��(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd nibr�� ]) exit(3); else if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local user.name dd x86-64.so.2 nibr��(dns block)detectportal.firefox.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack x86-64.so.2 s/li��(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd nibr�� ]) exit(3); else if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local user.name dd x86-64.so.2 nibr��(dns block)google.com/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd 0.so.0 om/elastic/kiban1 k/kibana/kibana v22.22.0/libexec/lib/node_modules/npm/bin/node-gyp-bin/ldd man(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack x86-64.so.2 s/li��(dns block)/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack ldd nibr�� ]) exit(3); else if (a[i] > b[i]) exit(0) git s/npm/bin/node-gyp-bin/npm --local user.name dd x86-64.so.2 nibr��(dns block)googlechromelabs.github.io/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js .git/copilot-hoo/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/lib/libwpe-1.0.so.1.9.3 /lib/ld-linux.so.2 b/li��(dns block)iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either: