Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,17 @@ describe('deriveEntityAnalyticsStatus', () => {
describe('entity store v2 (entity store is sole status driver)', () => {
const v2Base = { ...base, isEntityStoreV2Enabled: true };

it('returns enabled when V2 is enabled and store=running even if V1 feature flag is disabled', () => {
expect(
deriveEntityAnalyticsStatus({
...v2Base,
isEntityStoreFeatureFlagDisabled: true,
riskEngineStatus: RiskEngineStatusEnum.NOT_INSTALLED,
entityStoreStatus: 'running',
})
).toBe('enabled');
});

it('returns enabled when store=running regardless of risk engine status', () => {
expect(
deriveEntityAnalyticsStatus({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ export const deriveEntityAnalyticsStatus = ({
return 'enabling';
}

// V2 supersedes the V1 experimental feature flag — check it first
if (isEntityStoreV2Enabled) {
if (entityStoreStatus === 'installing') {
return 'enabling';
}
if (entityStoreStatus === 'error') {
return 'error';
}
return deriveEntityStoreOnlyStatus(entityStoreStatus);
}

if (isEntityStoreFeatureFlagDisabled) {
return deriveRiskEngineOnlyStatus(riskEngineStatus);
}
Expand All @@ -100,10 +111,6 @@ export const deriveEntityAnalyticsStatus = ({
return 'error';
}

if (isEntityStoreV2Enabled) {
return deriveEntityStoreOnlyStatus(entityStoreStatus);
}

return deriveCombinedStatus(riskEngineStatus, entityStoreStatus);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ export const useToggleEntityAnalytics = ({
setIsToggling(true);
try {
const riskOn = riskEngineStatus === RiskEngineStatusEnum.ENABLED;
const storeOn =
!isEntityStoreFeatureFlagDisabled && entityStoreStatus === StoreStatusEnum.running;
const storeOn = isEntityStoreV2Enabled
? entityStoreStatus === StoreStatusEnum.running
: !isEntityStoreFeatureFlagDisabled && entityStoreStatus === StoreStatusEnum.running;

if (isEntityStoreV2Enabled) {
if (storeOn) {
Expand Down
Loading