-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[kbn/i18n] remove npm-run-all #26297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7e08fd7
[kbn/i18n] remove npm-run-all
cf71703
Merge branch 'master' of github.com:elastic/kibana into remove/run-p
2bff63a
remove unnecessary package
a26d56e
loop through babel sub tasks and use helper for task name padding
0180749
add --source-maps flag
94a81b9
Merge branch 'master' of github.com:elastic/kibana into remove/run-p
fa0be20
update yarn.lock
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| require('../tasks/build_cli'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| const { resolve } = require('path'); | ||
|
|
||
| const getopts = require('getopts'); | ||
| const del = require('del'); | ||
| const supportsColor = require('supports-color'); | ||
| const { ToolingLog, withProcRunner, pickLevelFromFlags } = require('@kbn/dev-utils'); | ||
|
|
||
| const ROOT_DIR = resolve(__dirname, '..'); | ||
| const BUILD_DIR = resolve(ROOT_DIR, 'target'); | ||
|
|
||
| const padRight = (width, str) => | ||
| str.length >= width ? str : `${str}${' '.repeat(width - str.length)}`; | ||
|
|
||
| const unknownFlags = []; | ||
| const flags = getopts(process.argv, { | ||
| boolean: ['watch', 'help', 'source-maps'], | ||
| unknown(name) { | ||
| unknownFlags.push(name); | ||
| }, | ||
| }); | ||
|
|
||
| const log = new ToolingLog({ | ||
| level: pickLevelFromFlags(flags), | ||
| writeTo: process.stdout, | ||
| }); | ||
|
|
||
| if (unknownFlags.length) { | ||
| log.error(`Unknown flag(s): ${unknownFlags.join(', ')}`); | ||
| flags.help = true; | ||
| process.exitCode = 1; | ||
| } | ||
|
|
||
| if (flags.help) { | ||
| log.info(` | ||
| Simple build tool for @kbn/i18n package | ||
|
|
||
| --watch Run in watch mode | ||
| --source-maps Include sourcemaps | ||
| --help Show this message | ||
| `); | ||
| process.exit(); | ||
| } | ||
|
|
||
| withProcRunner(log, async proc => { | ||
| log.info('Deleting old output'); | ||
| await del(BUILD_DIR); | ||
|
|
||
| const cwd = ROOT_DIR; | ||
| const env = { ...process.env }; | ||
| if (supportsColor.stdout) { | ||
| env.FORCE_COLOR = 'true'; | ||
| } | ||
|
|
||
| log.info(`Starting babel and typescript${flags.watch ? ' in watch mode' : ''}`); | ||
| await Promise.all([ | ||
| ...['web', 'node'].map(subTask => | ||
| proc.run(padRight(10, `babel:${subTask}`), { | ||
| cmd: 'babel', | ||
| args: [ | ||
| 'src', | ||
| '--config-file', | ||
| require.resolve('../babel.config.js'), | ||
| '--out-dir', | ||
| resolve(BUILD_DIR, subTask), | ||
| '--extensions', | ||
| '.ts,.js,.tsx', | ||
| ...(flags.watch ? ['--watch'] : ['--quiet']), | ||
| ...(flags['source-maps'] ? ['--source-map', 'inline'] : []), | ||
| ], | ||
| wait: true, | ||
| env: { | ||
| ...env, | ||
| BABEL_ENV: subTask, | ||
| }, | ||
| cwd, | ||
| }) | ||
| ), | ||
|
|
||
| proc.run(padRight(10, 'tsc'), { | ||
| cmd: 'tsc', | ||
| args: [ | ||
| '--emitDeclarationOnly', | ||
| ...(flags.watch ? ['--watch', '--preserveWatchOutput', 'true'] : []), | ||
| ...(flags['source-maps'] ? ['--declarationMap', 'true'] : []), | ||
| ], | ||
| wait: true, | ||
| env, | ||
| cwd, | ||
| }), | ||
| ]); | ||
|
|
||
| log.success('Complete'); | ||
| }).catch(error => { | ||
| log.error(error); | ||
| process.exit(1); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.