Fix @elastic/eui/require-aria-label-for-modals lint violations across @elastic/kibana-esql files

src/platform/packages/private/kbn-esql-editor/src/editor_footer/discard_starred_query/discard_starred_query_modal.tsx

@@ -22,6 +22,7 @@ import {
   EuiFlexItem,
   EuiFlexGroup,
   EuiHorizontalRule,
+  useGeneratedHtmlId,
 } from '@elastic/eui';
 
 export interface DiscardStarredQueryModalProps {
@@ -34,15 +35,17 @@ export default function DiscardStarredQueryModal({ onClose }: DiscardStarredQuer
   const onTransitionModalDismiss = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
     setDismissModalChecked(e.target.checked);
   }, []);
+  const modalTitleId = useGeneratedHtmlId();
 
   return (
     <EuiModal
       onClose={() => onClose()}
       style={{ width: 700 }}
       data-test-subj="discard-starred-query-modal"
+      aria-labelledby={modalTitleId}
     >
       <EuiModalHeader>
-        <EuiModalHeaderTitle>
+        <EuiModalHeaderTitle id={modalTitleId}>
           {i18n.translate('esqlEditor.discardStarredQueryModal.title', {
             defaultMessage: 'Discard starred query',
           })}

src/platform/packages/private/kbn-esql-editor/src/editor_footer/errors_warnings_popover.tsx

@@ -155,13 +155,14 @@ export function ErrorsWarningsFooterPopover({
     return items;
   }, [items, dataErrorsControl]);
 
-  const { color, message } = getConstsByType(type, visibleItems.length);
+  const { color, message, label } = getConstsByType(type, visibleItems.length);
   const closePopover = useCallback(() => setIsPopoverOpen(false), [setIsPopoverOpen]);
 
   return (
     <EuiFlexItem grow={false}>
       <EuiFlexGroup gutterSize="xs" responsive={false} alignItems="center">
         <EuiPopover
+          aria-label={label}
           anchorPosition="downLeft"
           hasArrow={false}
           panelPaddingSize="none"

src/platform/packages/private/kbn-esql-editor/src/editor_footer/keyboard_shortcuts.tsx

@@ -97,6 +97,7 @@ export function KeyboardShortcuts() {
   return (
     <>
       <EuiPopover
+        aria-labelledby={labelId}
         data-test-subj="editorKeyboardShortcutsPopover"
         isOpen={isOpen}
         closePopover={() => setIsOpen(false)}

src/platform/packages/private/kbn-esql-editor/src/editor_menu/help_popover.tsx

@@ -297,6 +297,7 @@ export const HelpPopover: React.FC<{
   return (
     <>
       <EuiPopover
+        aria-label={helpLabel}
         button={
           <EuiToolTip position="top" content={helpLabel} disableScreenReaderOutput>
             <EuiButtonIcon

src/platform/packages/private/kbn-esql-editor/src/editor_visor/sources_dropdown.tsx

@@ -199,6 +199,9 @@ export function SourcesDropdown({ currentSources, onChangeSources }: SourcesDrop
           <EuiFormControlLayout compressed isDropdown fullWidth>
             <EuiPopover
               id={popoverId}
+              aria-label={i18n.translate('esqlEditor.visor.sourcesDropdownPopoverLabel', {
+                defaultMessage: 'Data sources',
+              })}
               button={createTrigger()}
               isOpen={isPopoverOpen}
               closePopover={() => setPopoverIsOpen(false)}

src/platform/packages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx

@@ -114,6 +114,9 @@ export const AddColumnPopover = ({
 
   return (
     <EuiPopover
+      aria-label={i18n.translate('indexEditor.columnHeaderEdit.addColumnPopoverLabel', {
+        defaultMessage: 'Add column',
+      })}
       button={triggerButton}
       isOpen={isPopoverOpen}
       closePopover={closePopover}

src/platform/packages/private/kbn-language-documentation/src/components/as_popover/index.tsx

@@ -48,6 +48,12 @@ function DocumentationPopover({
       }}
     >
       <EuiPopover
+        aria-label={i18n.translate('languageDocumentation.popoverAriaLabel', {
+          defaultMessage: '{lang} reference',
+          values: {
+            lang: language,
+          },
+        })}
         panelClassName="documentation__docs--overlay"
         panelPaddingSize="none"
         isOpen={isHelpMenuOpen}

src/platform/plugins/shared/esql/public/triggers/esql_controls/control_flyout/choose_column_popover.tsx

@@ -55,7 +55,14 @@ export function ChooseColumnPopover({
   );
 
   return (
-    <EuiPopover button={button} isOpen={isPopoverOpen} closePopover={closePopover}>
+    <EuiPopover
+      aria-label={i18n.translate('esql.flyout.chooseColumnPopoverLabel', {
+        defaultMessage: 'Choose a column',
+      })}
+      button={button}
+      isOpen={isPopoverOpen}
+      closePopover={closePopover}
+    >
       <EuiSelectable
         aria-label={i18n.translate('esql.flyout.chooseColumnList.label', {
           defaultMessage: 'Select a column',